Secret hiding base CI resource#5096
Merged
roypat merged 2 commits intofirecracker-microvm:feature/secret-hidingfrom Mar 24, 2025
Merged
Secret hiding base CI resource#5096roypat merged 2 commits intofirecracker-microvm:feature/secret-hidingfrom
roypat merged 2 commits intofirecracker-microvm:feature/secret-hidingfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5096 +/- ##
======================================================
Coverage 83.14% 83.14%
======================================================
Files 248 248
Lines 26925 26925
======================================================
Hits 22388 22388
Misses 4537 4537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
37b9dcc to
3bca636
Compare
roypat
reviewed
Mar 19, 2025
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
dae2d55 to
451a7d2
Compare
roypat
reviewed
Mar 20, 2025
Contributor
roypat
left a comment
roypat
left a comment
There was a problem hiding this comment.
Should we also add the "kernel builds" integration test as part of this? Just so that the code is tested/used straight away
roypat
reviewed
Mar 20, 2025
JackThomson2
force-pushed
the
ci/kernel_installation
branch
6 times, most recently
from
070590a to
ffcab3f
Compare
roypat
reviewed
Mar 21, 2025
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
ffcab3f to
c02988a
Compare
JackThomson2
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
JackThomson2
force-pushed
the
ci/kernel_installation
branch
2 times, most recently
from
cc851c5 to
9a7c7e9
Compare
roypat
previously approved these changes
Mar 21, 2025
kalyazin
reviewed
Mar 24, 2025
Creating a script to build and install a modified kernel with patches applied. Signed-off-by: Jack Thomson <jackabt@amazon.com>
Adding a new integration test to assert that the kernel build script will succeed. Signed-off-by: Jack Thomson <jackabt@amazon.com>
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
e4a88ee to
b642465
Compare
kalyazin
approved these changes
Mar 24, 2025
roypat
approved these changes
Mar 24, 2025
roypat
merged commit 08ee93c
into
firecracker-microvm:feature/secret-hiding
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adding the base script to be used for building custom kernels with secret hiding patches applied for testing
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.