visualization scripts for A/B tests#4923
Closed
ShadowCurse wants to merge 3 commits intofirecracker-microvm:mainfrom
Closed
visualization scripts for A/B tests#4923ShadowCurse wants to merge 3 commits intofirecracker-microvm:mainfrom
ShadowCurse wants to merge 3 commits intofirecracker-microvm:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4923 +/- ##
=======================================
Coverage 84.09% 84.09%
=======================================
Files 251 251
Lines 28061 28061
=======================================
Hits 23597 23597
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
ShadowCurse
force-pushed
the
ab_test_parsing
branch
2 times, most recently
from
1610ca6 to
507711b
Compare
Save A/B test fails to be able to do offline analysis. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add scripts for combining and plotting results of A/B runs. Move all A/B related scripts to the tools/ab Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Update links in the docs with new ab_test.py location Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
ab_test_parsing
branch
from
507711b to
8163526
Compare
Contributor
Author
|
Closing in favor if #5508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Save A/B test fails into
test_resultsdirectory and add scripts to combine and plot this data.Reason
Better A/B testing experience.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.