Skip to content

Conversation

@Augustifolia
Copy link
Contributor

I initially only intended to remove the initopts, but I got a bit carried away and fixed some other things as well. I have tried to explain my changes below.

Make all options editable after init time and some other fixes

  • Fixed some alignment issues (fixed itemMargin for the DirectBoxSizer. Fixed a tiling issue with DirectGridSizer)
  • Made sure all components are stored with unique names
  • Added some components to dynamic groups (to let the user specify options at init time for components that are created later, for example the tabs in DirectTabbedFrame)
  • Made sure to include options set at init time when creating components at a later time
  • Added the 'valueChangeCallback' to DirectSpinBox

Fixed some issues to work better with the DirectGuiDesigner

  • Fixed some properties in the .widget files
  • Made some widgets work better with a scale applied (the DGH functions takes the scale of the object into account, but depending on what you are doing this causes some issues. Perhaps those functions should have a parameter to change what node the scale is relative to.)
  • Made some widgets work better in pixel2d mode in DirectGuiDesigner (this was mainly done by setting better default values for the pixel2d mode)

Made some improvements to DirectDiagram among other things

  • Made sure kwargs passed at init time gets passed to components created later
  • Made pad work with DirectDiagram (I set a new default value for pad, so DirectDiagrams will look a bit different by default. Is that fine or do you want to keep the old look?)
  • Added 'NumberAreaPad' option to DirectDiagram (option to add some space between numbers on the side of the diagram and the lines)
  • Fixed some smaller bugs with DirectDiagram (stuff like making all data points have a datalabel)

Handle scaling better and fixed a refresh issue with DirectBoxSizer

  • Continued fixing scaling issues
  • When the DirectBoxSizer is used together with DirectAutoSizers and stuff is refreshed by a window resize some widgets might be placed incorrectly. This appears to be because the widgets are updated in the wrong order.

Sorry for the wall of text. If you are wondering about or want me to change something just let me know.

- Fixed some alignment issues
- Made sure all components are stored with unique names
- Added some components to dynamic groups
- Fixed some properties in the .widget files
- Made some widgets work better with a scale applied
- Made some widgets work better in pixel2d mode in DirectGuiDesigner
- Made sure kwargs passed at init time gets passed to components created later
- Made pad work with DirectDiagram
- Added 'NumberAreaPad' option to DirectDiagram
- Fixed some smaller bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant