Skip to content

Add support for sort param to get transactions endpoint #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for sort param to get transactions endpoint #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.17.1
current_version = 1.17.2
commit = false
tag = false

Expand Down
16 changes: 11 additions & 5 deletions fireblocks_sdk/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def deposit_from_linked_dda(self, account_id, amount, idempotency_key=None):

def get_transactions_with_page_info(self, before=0, after=None, status=None, limit=None, txhash=None,
assets=None, source_type=None, source_id=None, dest_type=None, dest_id=None,
next_or_previous_path=None):
next_or_previous_path=None, sort=None):
"""Gets a list of transactions matching the given filters or path.
Note that "next_or_previous_path" is mutually exclusive with other parameters.
If you wish to iterate over the nextPage/prevPage pages, please provide only the "next_or_previous_path" parameter from `pageDetails` response
Expand All @@ -352,6 +352,8 @@ def get_transactions_with_page_info(self, before=0, after=None, status=None, lim
NETWORK_CONNECTION, COMPOUND
dest_id (str, optional): Only gets transactions with given dest_id
next_or_previous_path (str, optional): get transactions matching the path, provided from pageDetails
sort (str, optional): Possible values are ASC or DESC, DESC is the default behavior for getting transaction
from latests to the oldest.
"""
if next_or_previous_path is not None:
if not next_or_previous_path:
Expand All @@ -362,10 +364,10 @@ def get_transactions_with_page_info(self, before=0, after=None, status=None, lim
return self._get_request(suffix_path, True)
else:
return self._get_transactions(before, after, status, limit, None, txhash, assets, source_type, source_id,
dest_type, dest_id, True)
dest_type, dest_id, sort, True)

def get_transactions(self, before=0, after=0, status=None, limit=None, order_by=None, txhash=None,
assets=None, source_type=None, source_id=None, dest_type=None, dest_id=None):
assets=None, source_type=None, source_id=None, dest_type=None, dest_id=None, sort=None):
"""Gets a list of transactions matching the given filters

Args:
Expand All @@ -387,12 +389,14 @@ def get_transactions(self, before=0, after=0, status=None, limit=None, order_by=
VAULT_ACCOUNT, EXCHANGE_ACCOUNT, INTERNAL_WALLET, EXTERNAL_WALLET, UNKNOWN_PEER, FIAT_ACCOUNT,
NETWORK_CONNECTION, COMPOUND
dest_id (str, optional): Only gets transactions with given dest_id
sort (str, optional): Possible values are ASC or DESC, DESC is the default behavior for getting transaction
from latests to the oldest.
"""
return self._get_transactions(before, after, status, limit, order_by, txhash, assets, source_type, source_id,
dest_type, dest_id)
dest_type, dest_id, sort)

def _get_transactions(self, before, after, status, limit, order_by, txhash, assets, source_type, source_id,
dest_type, dest_id, page_mode=False):
dest_type, dest_id, sort, page_mode=False):
path = "/v1/transactions"
params = {}

Expand Down Expand Up @@ -421,6 +425,8 @@ def _get_transactions(self, before, after, status, limit, order_by, txhash, asse
params['destType'] = dest_type
if dest_id:
params['destId'] = dest_id
if sort:
params['sort'] = sort
if params:
path = path + "?" + urllib.parse.urlencode(params)

Expand Down