Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions v2/openapi/fb-unified-openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,22 @@ tags:
Beta Feature – Limited Access.

On-ramp, off-ramp and bridging operations.

- name: Off Exchange
description: Endpoints used by external providers (exchanges) calling Fireblocks
for off-exchange collateral flows.
- name: Collateral webhooks
description: Webhook notifications sent by Fireblocks to exchanges for collateral events.
Comment on lines +52 to +56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use identifier style name, like in other tags: offExchange and collateralWebhooks.

Comment on lines +52 to +56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of adding tags without adding anything to these tags?

Comment on lines +52 to +56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file v2/openapi/fb-unified-openapi.yaml is autogenerated. A change like this should be made in v2/openapi/fb-provider-collateral-api.yaml and then fb-unified-openapi.yaml should be generated from it.


x-tagGroups:
- name: Providers to Fireblocks APIs
tags:
- Off Exchange
- name: Webhooks
tags:
- Collateral webhooks
Comment on lines +58 to +64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used tag groups until now, and I wouldn't start now. Definitely not without grouping other tags too. I'd remove this.



paths:
/capabilities:
get:
Expand Down