Move non-legacy examples to Swift Package Manager - #1666
Conversation
ecc3c6f to
3fbefa2
Compare
c1950a9 to
8ac405a
Compare
bacbb70 to
03f0619
Compare
|
checkpoint |
This reverts commit e937932.
|
checkpoint |
This reverts commit 0150020.
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
Nice!
None of my comments are blocking.
Any thoughts about an alternative or update to the dpebot to automatically update Firebase dependencies for SPM instead of CocoaPods?
|
|
||
| env: | ||
| SPM: false | ||
| SPM: true |
There was a problem hiding this comment.
Is the SPM environment variable still needed?
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer |
There was a problem hiding this comment.
Should the xcode-select be migrated to one of the common scripts?
There was a problem hiding this comment.
Definitely. Will do in future PR.
|
Thanks @paulb777 for review! I'm going to merge this in another feature branch as there is more related work to be done in removing theobjc qs and cleaning up the infra scripts.
This could be a GitHub Action that does a PR update and is triggered by the publishing of a firebase-ios-sdk tag. I know we could accomplish with vanilla GHA, but dpebot may also be able to do it. |
6 participants
@ncooke3: I think this is in a good state to merge. Main repo testing is looking good: firebase/firebase-ios-sdk#15338
Overall plan: