chore: dataconnect: use firebase bom instead of bespoke version specification #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Firebase dependency management in the Data Connect project by removing bespoke version specifications and switching to the Firebase BOM for consistency.
- Removed explicit version definitions for firebaseAuth and firebaseDataConnect in the TOML file.
- Updated the app build file to import the Firebase BOM and reference Firebase dependencies without explicit versions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Removed explicit Firebase version specifications in favor of managing via BOM |
| dataconnect/app/build.gradle.kts | Updated dependency declarations to use the Firebase BOM and reordered comments |
Comments suppressed due to low confidence (1)
gradle/libs.versions.toml:3
- Ensure that all Firebase dependencies are managed consistently using the Firebase BOM. If supported, consider updating firebase-ai to also use the BOM for a streamlined version management.
-firebaseAuth = "23.2.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.