-
Notifications
You must be signed in to change notification settings - Fork 613
fix(py): fix the encoded media parts in response with google-genai pl… #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(py): fix the encoded media parts in response with google-genai pl… #4000
Conversation
Summary of ChangesHello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue with how media parts are encoded in responses within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix the encoding of media parts in responses from the google-genai plugin by using data URIs. The changes correctly format image data into data URIs when creating Media parts in imagen.py and utils.py. The tests are also updated to handle the new data URI format. However, I found an issue in utils.py where a base64-encoded string is passed to a field expecting bytes when converting a MediaPart to a Gemini part. This will likely cause an error. I've provided a suggestion to fix this and make the code more robust by handling unsupported URL formats.
This PR is to fix the google-genai plugin encoding problem observed during the bug bash of Genkit Python.
CHANGELOG: