Skip to content

Conversation

@MengqinShen
Copy link
Contributor

@MengqinShen MengqinShen commented Dec 17, 2025

CHANGELOG:

  1. Add prompt files to test variant, name and extension
  2. Create a test file for prompt loading test
  3. Add GoogleAI as plugin
  4. Update root uv.lock and pyproject.toml

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Python sample application (prompt_demo) designed to showcase how to load and manage prompts from a local directory using the genkit library. It provides a practical example of using load_prompt_folder to register prompts, including those with simple variable placeholders, and verifies their successful loading into the Genkit registry. This addition helps developers understand and implement prompt management within their Genkit projects.

Highlights

  • New Sample Application: Introduced a new Python sample application, prompt_demo, to demonstrate prompt loading capabilities.
  • Directory Prompt Loading: The sample showcases how to load multiple prompt files from a specified directory using genkit.blocks.prompt.load_prompt_folder.
  • Example Prompt Files: Added several example prompt files (dot.name.test.prompt, hello.prompt, hello.variant.prompt) to illustrate different prompt structures and variable interpolation.
  • Project Configuration: Included a pyproject.toml file to define the project metadata and dependencies for the new prompt_demo sample.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new sample to demonstrate loading prompts from files and directories. The implementation is straightforward and serves its purpose as a demonstration. I've identified a few areas for improvement. In the main Python script, the logic for filtering prompts can be made more robust. Additionally, the sample prompt files contain leading newlines, which will be included in the prompt content. I've suggested removing these if they are not intentional to prevent unexpected whitespace in the rendered prompts.

@MengqinShen MengqinShen requested a review from yesudeep December 17, 2025 19:29
@MengqinShen MengqinShen force-pushed the elisa/feat/add-prompt-loading-sample-test branch from 429bbcd to b111925 Compare December 17, 2025 21:53
@MengqinShen MengqinShen marked this pull request as ready for review December 17, 2025 21:56
@yesudeep yesudeep enabled auto-merge (squash) December 17, 2025 21:58
@yesudeep yesudeep merged commit b4da586 into main Dec 17, 2025
10 checks passed
@yesudeep yesudeep deleted the elisa/feat/add-prompt-loading-sample-test branch December 17, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config feature New feature or request python Python test

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants