feat(js/plugins/compat-oai): Add reasoning_content and json_schema support to OpenAI Compatible API plugin #3679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @pavelgj, just wanted to kindly check if you’ve had a chance to look at this PR. |
|
@ssbushi could you please take a look? |
This commit adds comprehensive support for handling reasoning_content in OpenAI Compatible API Chat Completions responses, supporting both streaming and non-streaming scenarios. The implementation ensures that models supporting reasoning_content can properly return their reasoning traces, with optimized content assembly and enhanced response_format handling. **CHANGELOG:** - [x] Add reasoning_content handling in fromOpenAIChoice and fromOpenAIChunkChoice - [x] Implement direct content assembly by pushing reasoning and content parts to content array - [x] Update response_format handling in toOpenAIRequestBody to support schema-based responses - [x] Add comprehensive test cases for reasoning_content in both streaming and non-streaming functions - [x] Add test for json_schema response_format in toOpenAIRequestBody **Key features:** - Enables proper reasoning trace returns from supporting models - Enhanced compatibility with schema-based response formats - Complete test coverage for new reasoning_content functionality
neokn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds comprehensive support for handling reasoning_content in OpenAI Compatible API Chat Completions responses, supporting both streaming and non-streaming scenarios. The implementation ensures that models supporting reasoning_content can properly return their reasoning traces, with optimized content assembly and enhanced response_format handling.
CHANGELOG:
Description here... Help the reviewer by:
OpenAI it self not support
reasoning_contentbutsupport
reasoning_contentwhen using reasoning modelChecklist (if applicable):