feat(js/plugins/ollama): migrate ollama plugin to v2 plugin API #3547

HassanBahati · 2025-09-11T12:41:21Z

Fixes #3456

Plugin migration guide

Notable Changes

added interface ResolveActionOptions for cleaner destructuring of resolveActions args
added a OllamaEmbedderConfig schema so that serverAddress comes through on request options.
used OllamaConfigSchema in model<> for better type safety
added several test suites for better coverage
Updated and added integration tests with the core genkit framework, for streaming responses and tool calls.
All existing plugin tests pass

Testing

Checked that the models and embedders load with the same names/prefixes on the UI.
Checked that at least one model works consistent with pre-migration on the UI.

Using a model string ('pluginName/modelName'), checked using a flow works consistent with pre-migration.

Tested that the trace on flows are the same.

Tested error response from model.

Tested ollama().resolve(...).

js/plugins/ollama/src/index.ts

js/plugins/ollama/tests/model_test.ts

js/plugins/ollama/src/embeddings.ts

js/plugins/ollama/src/index.ts

js/plugins/ollama/src/embeddings.ts

js/plugins/ollama/tests/embeddings_test.ts

js/plugins/ollama/tests/model_test.ts

js/plugins/ollama/src/index.ts

js/plugins/ollama/src/embeddings.ts

js/plugins/ollama/package.json

js/plugins/ollama/src/index.ts

js/plugins/ollama/src/embeddings.ts

js/plugins/ollama/package.json

js/plugins/ollama/src/index.ts

js/plugins/ollama/tests/list_test.ts

js/plugins/ollama/src/index.ts

…e tests

…nitialized

…e testing

…in same place

… plugins implementation

github-project-automation bot added this to Genkit Backlog Sep 11, 2025

github-actions bot added the js label Sep 11, 2025

cabljac reviewed Sep 16, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac reviewed Sep 16, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac reviewed Sep 16, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac reviewed Sep 16, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac reviewed Sep 16, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac reviewed Sep 16, 2025

View reviewed changes

js/plugins/ollama/tests/model_test.ts Show resolved Hide resolved

HassanBahati commented Sep 18, 2025

View reviewed changes

js/plugins/ollama/src/embeddings.ts Show resolved Hide resolved

CorieW reviewed Sep 26, 2025

View reviewed changes

js/plugins/ollama/src/embeddings.ts Outdated Show resolved Hide resolved

js/plugins/ollama/src/embeddings.ts Outdated Show resolved Hide resolved

js/plugins/ollama/src/index.ts Show resolved Hide resolved

cabljac reviewed Sep 29, 2025

View reviewed changes

js/plugins/ollama/src/embeddings.ts Outdated Show resolved Hide resolved

cabljac reviewed Oct 6, 2025

View reviewed changes

js/plugins/ollama/tests/embeddings_test.ts Outdated Show resolved Hide resolved

cabljac reviewed Oct 6, 2025

View reviewed changes

js/plugins/ollama/tests/embeddings_test.ts Outdated Show resolved Hide resolved

cabljac reviewed Oct 6, 2025

View reviewed changes

js/plugins/ollama/tests/model_test.ts Show resolved Hide resolved

github-actions bot added the config label Oct 7, 2025

CorieW reviewed Oct 7, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

CorieW reviewed Oct 7, 2025

View reviewed changes

js/plugins/ollama/src/embeddings.ts Show resolved Hide resolved

cabljac reviewed Oct 7, 2025

View reviewed changes

js/plugins/ollama/package.json Outdated Show resolved Hide resolved

cabljac reviewed Oct 7, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac reviewed Oct 7, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac reviewed Oct 7, 2025

View reviewed changes

js/plugins/ollama/src/embeddings.ts Outdated Show resolved Hide resolved

dackers86 reviewed Oct 7, 2025

View reviewed changes

cabljac reviewed Oct 13, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

cabljac force-pushed the @invertase/migrate-ollama-plugin-to-pluginv2-api branch 2 times, most recently from 03dbebe to b0848d8 Compare October 13, 2025 15:57

CorieW reviewed Oct 14, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

js/plugins/ollama/src/index.ts Show resolved Hide resolved

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

js/plugins/ollama/src/index.ts Show resolved Hide resolved

dackers86 reviewed Oct 14, 2025

View reviewed changes

js/plugins/ollama/tests/list_test.ts Outdated Show resolved Hide resolved

dackers86 reviewed Oct 14, 2025

View reviewed changes

js/plugins/ollama/src/index.ts Outdated Show resolved Hide resolved

HassanBahati added 2 commits October 14, 2025 11:32

feat(js/plugins/ollama): migrate ollama plugin to v2 plugin API

831f634

chore(js/plugins/ollama): migrate embeddings

2487bff

HassanBahati and others added 19 commits October 14, 2025 11:32

chore(js/plugins/ollama): update types

6220e03

feat(js/plugins/ollama): migrate ollama plugin to v2 plugins API

1dd55ce

chore(js/plugins/ollama): add back mock tool call response

16f53ce

chore(js/plugins/ollama): input => request

755bace

refactor(js/plugins/ollama): extract constants to own module, fix som…

c32af58

…e tests

(js/plugins/ollama): ensure all embeddings tests are executed

9ad0416

tests(js/plugins/ollama): add tests to cover cases when genkit isnt i…

ebe6143

…nitialized

tests(js/plugins/ollama): add live tests

9bfbee9

test(js/plugins/ollama): update model tests

84a81f8

fix(js/plguings/ollama): change to opts.streamingRequested and improv…

d7c8115

…e testing

refactor(js/plugins/ollama): improve model tests

9592137

refactor(js/plguings/ollama): use namespace and keep plugin function …

9468b02

…in same place

fix(js/plguings/ollama): revert to using prefixes

ff348b3

refactor(js/plugins/ollama): clean up default args in ollamaPlugin

9215cab

refactor(js/plugins/ollama): extract initializer as with the original…

68dd595

… plugins implementation

fix(js/plugins/ollama): fix prefix in list method, and add tests

2703c9a

fix(js/plugins/ollama): restore specifying serverAddress at request time

c0b1913

fix(js/plugins/ollama): restore old method name and add a config schema

13423cc

fix(js/plugins/ollama): address PR review comments

5a8ebf9

cabljac force-pushed the @invertase/migrate-ollama-plugin-to-pluginv2-api branch from 647d64a to 5a8ebf9 Compare October 14, 2025 10:33

cabljac added 2 commits October 14, 2025 14:30

fix(js/plugins/ollama): dont pass in serverAddress if we dont need to

99ec01c

fix(js/plugins/ollama): keep index:0 in streaming callback call

98d718d

feat(js/plugins/ollama): migrate ollama plugin to v2 plugin API #3547

Are you sure you want to change the base?

feat(js/plugins/ollama): migrate ollama plugin to v2 plugin API #3547

Conversation

HassanBahati commented Sep 11, 2025 • edited by CorieW Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HassanBahati commented Sep 11, 2025 •

edited by CorieW

Loading