fix(cli): fix ui:start on Windows (and machines with spaces in path) #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the genkit ui:start command on Windows and machines with spaces in file paths by properly quoting command arguments. The issue occurs when paths contain spaces, causing command execution to fail due to improper argument parsing.
- Wraps the spawn command and arguments in double quotes to handle spaces correctly
- Updates debug logging to reflect the quoted command format
CorieW
force-pushed
the
@invertase/cli-uistart-windows-fix
branch
from
1223ccc to
80b92a9
Compare
CorieW
force-pushed
the
@invertase/cli-uistart-windows-fix
branch
2 times, most recently
from
a186f7c to
c2d13dd
Compare
CorieW
force-pushed
the
@invertase/cli-uistart-windows-fix
branch
from
c2d13dd to
0e37f53
Compare
cabljac
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes running
genkit ui:starton WIndows.Should also fix running the command on machines that happen to include spaces in paths.
Checklist (if applicable):