Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update codelab-chat-with-a-pdf.md #2195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

thedmail
Copy link
Contributor

docs: Backports corrections made in google3 (reverts a bunch of angle brackets that got into the file somehow).

Description here... Help the reviewer by:

  • linking to an issue that includes more details
  • if it's a new feature include samples of how to use the new feature
  • (optional if issue link is provided) if you fixed a bug include basic bug details

Checklist (if applicable):

Backports corrections made in google3 (reverts a bunch of angle brackets that got into the file somehow).
@thedmail thedmail requested a review from peterfriese February 28, 2025 07:35
@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 28, 2025
Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David - I added these angle brackets to mark the entire block as a note block. I did check this works fine on DevSite before making the change on GitHub.

Fixes "Note:" block to conform to DevSite style.

DevSite Markdown doesn't seem to have a solution for doing a Note that contains bullets and also conforms to the DevSite Note style. But they provide an alternative HTML-based solution, so that's what I've used here.
@thedmail
Copy link
Contributor Author

Hi David - I added these angle brackets to mark the entire block as a note block. I did check this works fine on DevSite before making the change on GitHub.

Thanks, Peter. It turns out that we were both doing it wrong. :-P I just uploaded a new commit to address the issue.

@thedmail thedmail requested a review from peterfriese March 3, 2025 18:58
Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we could use plain Markdown, but if this is the way we need to things, I'll (begrudgingly) approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants