Skip to content

Node 12 #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Node 12 #793

merged 5 commits into from
Dec 9, 2020

Conversation

jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented Dec 3, 2020

Summary

Like #437 moved this repo from Node 7 to Node 8, this PR moves us from Node 8 to Node 12. We're doing this because (1) Node 8 is end-of-life, and (2) Cloud Functions support for the Node 8 runtime was deprecated on June 5, 2020.

Note that, after this update, samples in this repository will require a billing account to deploy. Per the pricing guide:

Node.js 10 or later runtimes require the Pay as you go (Blaze) plan

Status

  • Update engines field to 12 in package.json
  • Update firebase-functions and firebase-admin version in package.json
  • Update firebase version in package.json and *.html files
  • Update README.md with a note about Node 12 and Blaze plan required
  • Manually test a subset of samples to make sure they still build, deploy, and run:
    • Quickstarts:
      • HTTPS trigger quickstart: Time Server
      • Hosting triggered HTTPS function quickstart: Big Ben
      • Uppercaser for Realtime Database
      • Uppercaser for Cloud Firestore
      • Cloud Storage trigger quickstart: Thumbnail generator
      • Auth trigger quickstart: Welcome Email
      • PubSub trigger quickstart: Hello World
      • Crashlytics trigger quickstart: Crashlytics Email Notifier
      • Test Lab trigger quickstart: Log when a matrix completes
    • Other samples:
      • Write Cloud Functions using TypeScript (to check TS compilation)
      • Isomorphic React App (to check that the client SDK updates don't break it)
      • Moderate offensive images (to check for Cloud Vision API incompatibility)

⚠️ Help wanted: Anyone that has some time to pull this branch, test one of the samples, and comment in this PR whether it works or whether the Node 12 migration broke it, would be a huge help!

@google-cla google-cla bot added the cla: yes label Dec 3, 2020
@jhuleatt jhuleatt requested a review from samtstern December 3, 2020 20:16
"firebase": "7.9.2",
"firebase-admin": "8.9.2",
"firebase-functions": "3.3.0",
"firebase": "^8.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with this one, import styles changed

@jhuleatt jhuleatt marked this pull request as ready for review December 3, 2020 22:14
@jhuleatt jhuleatt merged commit ded0ccc into master Dec 9, 2020
@jhuleatt jhuleatt mentioned this pull request Jun 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants