Skip to content

Update getToken from functinosOauthClient #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Update getToken from functinosOauthClient #462

merged 1 commit into from
Sep 10, 2018

Conversation

luskin
Copy link

@luskin luskin commented Sep 9, 2018

The sample code shows to set the results of getToken directly to the variable tokens however tokens is now a property of the response so you need to store the tokens object from within the response as google states here:

https://github.com/google/google-api-nodejs-client:

const {tokens} = await oauth2Client.getToken(code)
oauth2Client.setCredentials(tokens);

The sample code shows to set the results of `getToken` directly to the variable tokens however tokens is now a property of the response so you need to store the tokens object from within the response as google states here:

https://github.com/google/google-api-nodejs-client:
```
const {tokens} = await oauth2Client.getToken(code)
oauth2Client.setCredentials(tokens);
```
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@luskin
Copy link
Author

luskin commented Sep 9, 2018

I have signed it!

@googlebot
Copy link

CLAs look good, thanks!

@nicolasgarnier nicolasgarnier merged commit d88bece into firebase:Node-8 Sep 10, 2018
@nicolasgarnier
Copy link
Contributor

Thanks @luskin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants