Skip to content

Update getToken from functinosOauthClient - #462

Merged
nicolasgarnier merged 1 commit into
firebase:Node-8from
luskin:patch-1
Sep 10, 2018
Merged

nicolasgarnier merged 1 commit into
firebase:Node-8from
luskin:patch-1

Conversation

@luskin

@luskin luskin commented Sep 9, 2018

Copy link
Copy Markdown

The sample code shows to set the results of getToken directly to the variable tokens however tokens is now a property of the response so you need to store the tokens object from within the response as google states here:

https://github.com/google/google-api-nodejs-client:

const {tokens} = await oauth2Client.getToken(code)
oauth2Client.setCredentials(tokens);

The sample code shows to set the results of `getToken` directly to the variable tokens however tokens is now a property of the response so you need to store the tokens object from within the response as google states here:

https://github.com/google/google-api-nodejs-client:
```
const {tokens} = await oauth2Client.getToken(code)
oauth2Client.setCredentials(tokens);
```
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@luskin

luskin commented Sep 9, 2018

Copy link
Copy Markdown
Author

I have signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@nicolasgarnier
nicolasgarnier merged commit d88bece into firebase:Node-8 Sep 10, 2018
@nicolasgarnier

Copy link
Copy Markdown
Contributor

Thanks @luskin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants