Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FDC connector evolution warnings. #8023

Merged
merged 16 commits into from
Jan 3, 2025
Merged

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Dec 3, 2024

Description

Surface connector evolution warnings for Firebase Data Connect during firebase deploy, gated behind the fdcconnectorevolution experiment flag. See go/fdc-connector-evolution-cli for a detailed description of desired behavior.

Scenarios Tested

  • firebase deploy
  • firebase deploy --force
  • firebase deploy --non-interactive
  • firebase deploy --non-interactive --force
  • firebase deploy --dry-run
  • firebase deploy --dry-run --force
  • firebase deploy --dry-run --non-interactive
  • firebase deploy --dry-run --non-interactive --force

Sample Commands

firebase deploy
Screenshot 2024-12-18 at 4 23 17 PM

@rosalyntan rosalyntan marked this pull request as ready for review December 18, 2024 21:33
@rosalyntan rosalyntan requested a review from joehan December 18, 2024 21:34
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a few nits and one place that I think we should add unit tests.

src/dataconnect/build.ts Outdated Show resolved Hide resolved
src/dataconnect/build.ts Outdated Show resolved Hide resolved
src/dataconnect/build.ts Outdated Show resolved Hide resolved
src/dataconnect/build.ts Outdated Show resolved Hide resolved
src/dataconnect/build.ts Outdated Show resolved Hide resolved
@rosalyntan rosalyntan requested a review from joehan December 31, 2024 01:29
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if fixing /src/apphosting/utils.spec.ts lets us clean this up

src/dataconnect/build.spec.ts Outdated Show resolved Hide resolved
src/dataconnect/build.spec.ts Outdated Show resolved Hide resolved
@rosalyntan rosalyntan enabled auto-merge (squash) January 3, 2025 20:19
@rosalyntan rosalyntan merged commit ba3fa99 into master Jan 3, 2025
37 of 46 checks passed
@rosalyntan rosalyntan deleted the rosalyntan.evo branch January 3, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants