Skip to content

Throw Operation Not Allowed for Invalid Auth Endpoint #9013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 13, 2025
Merged

Throw Operation Not Allowed for Invalid Auth Endpoint #9013

merged 6 commits into from
May 13, 2025

Conversation

mansisampat
Copy link
Contributor

@mansisampat mansisampat commented May 12, 2025 •
edited
Loading

Discussion

The change throw Operation Not Allowed for Invalid Auth Endpoint i.e. for following cases -

  • Case 1: Auth instance does not have tenantConfig initialized and method hitting the Regional_Endpoint
  • Case 2: Auth instance has tenantConfig initialized and method hitting the Endpoint (default).

Testing

  • Tested using the Demo App.
  • Added Unit Test

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c9005b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 12, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (fe8387e)Merge (9489393)Diff
    browser193 kB195 kB+2.16 kB (+1.1%)
    cordova166 kB168 kB+2.19 kB (+1.3%)
    main147 kB149 kB+1.45 kB (+1.0%)
    module193 kB195 kB+2.16 kB (+1.1%)
    react-native165 kB167 kB+1.31 kB (+0.8%)

  • @firebase/auth-cordova

    TypeBase (fe8387e)Merge (9489393)Diff
    browser166 kB168 kB+2.19 kB (+1.3%)
    module166 kB168 kB+2.19 kB (+1.3%)

  • @firebase/auth-web-extension

    TypeBase (fe8387e)Merge (9489393)Diff
    browser142 kB145 kB+2.16 kB (+1.5%)
    main160 kB160 kB+876 B (+0.5%)
    module142 kB145 kB+2.16 kB (+1.5%)

  • @firebase/auth/internal

    TypeBase (fe8387e)Merge (9489393)Diff
    browser204 kB206 kB+2.16 kB (+1.1%)
    main174 kB175 kB+973 B (+0.6%)
    module204 kB206 kB+2.16 kB (+1.1%)

  • bundle

    TypeBase (fe8387e)Merge (9489393)Diff
    auth (Anonymous)77.9 kB79.5 kB+1.57 kB (+2.0%)
    auth (EmailAndPassword)88.0 kB89.6 kB+1.55 kB (+1.8%)
    auth (GoogleFBTwitterGitHubPopup)105 kB107 kB+1.58 kB (+1.5%)
    auth (GooglePopup)102 kB104 kB+1.58 kB (+1.5%)
    auth (GoogleRedirect)102 kB104 kB+1.58 kB (+1.5%)
    auth (Phone)95.5 kB97.0 kB+1.53 kB (+1.6%)

  • firebase

    TypeBase (fe8387e)Merge (9489393)Diff
    firebase-auth-compat.js141 kB143 kB+1.26 kB (+0.9%)
    firebase-auth-cordova.js138 kB140 kB+1.52 kB (+1.1%)
    firebase-auth-web-extension.js121 kB122 kB+1.48 kB (+1.2%)
    firebase-auth.js158 kB160 kB+1.43 kB (+0.9%)
    firebase-compat.js797 kB799 kB+1.28 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jLbPc6FPhD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 12, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (359,919 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4YbRFQ3pfz.html

mansisampat
mansisampat commented May 13, 2025
View reviewed changes
Copy link
Contributor Author

@mansisampat mansisampat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Unit Test.

@mansisampat mansisampat requested a review from a team as a code owner May 13, 2025 06:10
pashanka
pashanka approved these changes May 13, 2025
View reviewed changes
packages/auth/src/api/index.test.ts Outdated
@@ -595,4 +602,34 @@ describe('api/_performApiRequest', () => {
.and.not.have.property('tenantId');
});
});

context('throws Operation now allowed exception', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:now -> not

@mansisampat mansisampat merged commit 326221d into gcip-byociam-web May 13, 2025
21 checks passed
@mansisampat mansisampat deleted the sammansi-gcip-byociam-web branch May 13, 2025 08:09
mansisampat added a commit that referenced this pull request May 13, 2025
@mansisampat
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013)
0edbdf5
mansisampat added a commit that referenced this pull request May 13, 2025
@mansisampat
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
7713281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashanka pashanka pashanka approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mansisampat @google-oss-bot @pashanka