Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image Generation support using Imagen #8683

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Conversation

dlarocque
Copy link
Contributor

WIP

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: c3173a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
firebase Minor
@firebase/vertexai Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some nits (mostly about doc formatting) and small questions.

common/api-review/vertexai.api.md Outdated Show resolved Hide resolved
packages/vertexai/src/api.test.ts Outdated Show resolved Hide resolved
packages/vertexai/src/models/imagen-model.ts Outdated Show resolved Hide resolved
packages/vertexai/src/models/imagen-model.test.ts Outdated Show resolved Hide resolved
packages/vertexai/src/requests/request-helpers.ts Outdated Show resolved Hide resolved
packages/vertexai/src/requests/response-helpers.ts Outdated Show resolved Hide resolved
packages/vertexai/src/types/imagen/requests.ts Outdated Show resolved Hide resolved
@dlarocque dlarocque changed the title WIP Add Image Generation support with Imagen Jan 3, 2025
@dlarocque dlarocque changed the title Add Image Generation support with Imagen Add Image Generation support using Imagen Jan 3, 2025
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (4e6a5c6)Merge (1cfca7d)Diff
    browser381 kB380 kB-334 B (-0.1%)
    main589 kB589 kB-372 B (-0.1%)
    module381 kB380 kB-334 B (-0.1%)
    react-native381 kB380 kB-334 B (-0.1%)
  • @firebase/firestore-lite

    TypeBase (4e6a5c6)Merge (1cfca7d)Diff
    browser112 kB112 kB-393 B (-0.4%)
    main154 kB154 kB-421 B (-0.3%)
    module112 kB112 kB-393 B (-0.4%)
    react-native112 kB112 kB-393 B (-0.3%)
  • @firebase/vertexai

    TypeBase (4e6a5c6)Merge (1cfca7d)Diff
    browser29.0 kB33.5 kB+4.47 kB (+15.4%)
    main29.9 kB34.4 kB+4.58 kB (+15.3%)
    module29.0 kB33.5 kB+4.47 kB (+15.4%)
  • bundle

    15 size changes

    TypeBase (4e6a5c6)Merge (1cfca7d)Diff
    firestore (CSI Auto Indexing Disable and Delete)271 kB271 kB-196 B (-0.1%)
    firestore (CSI Auto Indexing Enable)271 kB271 kB-196 B (-0.1%)
    firestore (Persistence)303 kB302 kB-159 B (-0.1%)
    firestore (Query Cursors)250 kB249 kB-159 B (-0.1%)
    firestore (Query)247 kB247 kB-159 B (-0.1%)
    firestore (Read data once)235 kB235 kB-159 B (-0.1%)
    firestore (Read Write w Persistence)327 kB327 kB-159 B (-0.0%)
    firestore (Realtime updates)237 kB237 kB-159 B (-0.1%)
    firestore (Transaction)214 kB214 kB-196 B (-0.1%)
    firestore (Write data)214 kB214 kB-196 B (-0.1%)
    firestore-lite (Query Cursors)103 kB103 kB-196 B (-0.2%)
    firestore-lite (Query)99.4 kB99.2 kB-196 B (-0.2%)
    firestore-lite (Read data once)74.8 kB74.6 kB-196 B (-0.3%)
    firestore-lite (Transaction)100 kB99.9 kB-196 B (-0.2%)
    firestore-lite (Write data)84.4 kB84.2 kB-196 B (-0.2%)

  • firebase

    TypeBase (4e6a5c6)Merge (1cfca7d)Diff
    firebase-compat.js791 kB791 kB-154 B (-0.0%)
    firebase-firestore-compat.js339 kB338 kB-154 B (-0.0%)
    firebase-firestore-lite.js131 kB130 kB-393 B (-0.3%)
    firebase-firestore.js439 kB439 kB-334 B (-0.1%)
    firebase-vertexai.js24.2 kB27.3 kB+3.05 kB (+12.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZKPkJ5oihY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2025

Size Analysis Report 1

This report is too large (536,834 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3k35GUTfGn.html

@dlarocque dlarocque requested a review from hsubox76 February 3, 2025 17:39
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, don't forget to add the changeset.

packages/vertexai/src/models/imagen-model.ts Outdated Show resolved Hide resolved
packages/vertexai/src/models/vertexai-model.test.ts Outdated Show resolved Hide resolved
packages/vertexai/src/models/vertexai-model.ts Outdated Show resolved Hide resolved
packages/vertexai/src/requests/response-helpers.ts Outdated Show resolved Hide resolved
packages/vertexai/src/types/imagen/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants