-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Infra] Restore Danger #15638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Infra] Restore Danger #15638
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
c7353e2 to
b2d6845
Compare
b2d6845 to
a1a9a71
Compare
|
/gemini summarize |
Summary of ChangesThis pull request focuses on re-enabling and modernizing the Danger CI/CD tool within the project's infrastructure. It involves upgrading the Danger gem to its latest version and adjusting the GitHub Actions workflow to use a more secure, short-lived Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the danger gem from version 8.4.5 to 9.5.3, which also updates the Gemfile.lock file with the corresponding dependency changes. The purpose of this change, as described, is to restore Danger's functionality, particularly for managing pull request labels, by leveraging the pull_request_target trigger which provides access to a token with greater permissions. The changes in the Gemfile and Gemfile.lock are consistent with a standard dependency update and appear correct.
pull_request_targetinstead ofpull_requestfor access to tokenAccording to Gemini, this won't actually be able to update labels until it is merged to
main.The potential vulnerability should be addressed since actions are locked down in the repo configuration.
#no-changelog