Skip to content

Conversation

@paulb777
Copy link
Member

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@paulb777 paulb777 marked this pull request as draft December 23, 2025 02:27
@paulb777
Copy link
Member Author

/gemini summarize

@gemini-code-assist
Copy link
Contributor

Summary of Changes

This pull request focuses on stabilizing and updating the integration test suite. It introduces a new Gemini model, gemini-3-flash-preview, into the testing framework and adjusts existing test assertions to correctly validate its behavior, particularly concerning token usage metadata. Additionally, it includes a project configuration change to manage test file inclusion and temporarily disables certain free-tier test configurations to ensure the test suite remains green.

Highlights

  • Test Project Configuration: An exception has been added to the IntegrationTests-SPM target in the Xcode project file to exclude LiveSessionTests.swift from the build process.
  • New Model Integration: The gemini-3-flash-preview model has been added to the ModelNames constants and included in the generateContent integration tests.
  • Test Assertion Adjustments: Assertions for usageMetadata in GenerateContentIntegrationTests have been updated to specifically handle thoughtsTokenCount, candidatesTokenCount, and totalTokenCount for gemini-3 models, reflecting their unique tokenization behavior.
  • Temporary Test Configuration Changes: Several googleAI_v1beta_freeTier configurations have been temporarily commented out in various integration tests and the InstanceConfig enum, likely to address current test failures or instability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • FirebaseAI/Tests/TestApp/FirebaseAITestApp.xcodeproj/project.pbxproj
    • Added a PBXFileSystemSynchronizedBuildFileExceptionSet to exclude Integration/LiveSessionTests.swift from the IntegrationTests-SPM target.
  • FirebaseAI/Tests/TestApp/Sources/Constants.swift
    • Added gemini3FlashPreview as a new static constant for model names.
  • FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
    • Included gemini3FlashPreview in the generateContent test cases.
    • Modified usageMetadata assertions to account for gemini-3 models' specific thoughtsTokenCount, candidatesTokenCount, and totalTokenCount values.
    • Commented out googleAI_v1beta_freeTier configurations in generateContentWithThinking and generateContentStream tests.
  • FirebaseAI/Tests/TestApp/Tests/Utilities/InstanceConfig.swift
    • Commented out googleAI_v1beta_freeTier from the InstanceConfig enum.
Activity
  • gemini-code-assist[bot] provided information on using Gemini Code Assist.
  • paulb777 requested a summary from Gemini Code Assist.

@paulb777
Copy link
Member Author

/gemini review

@google-oss-bot
Copy link

Danger has errored

[!] Invalid Dangerfile file: POST https://api.github.com/repos/firebase/firebase-ios-sdk/issues/15637/labels: 403 - Must have admin rights to Repository. // See: https://docs.github.com/rest/issues/labels#add-labels-to-an-issue. Updating the Danger gem might fix the issue. Your Danger version: 8.4.5, latest Danger version: 9.5.3

 #  from Dangerfile:43
 #  -------------------------------------------
 #    repo_name = "firebase/firebase-ios-sdk"
 >    github.api.add_labels_to_an_issue(repo_name, issue_number, label_array)
 #  end
 #  -------------------------------------------

Generated by 🚫 Danger

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the new gemini-3-flash-preview model by adding it to the ModelNames enum and including it in integration tests for content generation. The changes update token count assertions in GenerateContentIntegrationTests.swift to specifically handle thoughtsTokenCount and candidatesTokenCount for gemini-3 models. Additionally, several existing test configurations related to googleAI_v1beta_freeTier and gemini2_5_Flash models have been commented out across test files and the InstanceConfig enum, and an Xcode project file was modified to exclude LiveSessionTests.swift from a build target. A review comment suggests improving the robustness of the totalTokenCount assertion for gemini-3 models by calculating it as the sum of promptTokenCount, candidatesTokenCount, and thoughtsTokenCount instead of using a hardcoded value.

@paulb777 paulb777 marked this pull request as ready for review December 23, 2025 14:48
@paulb777 paulb777 marked this pull request as draft December 23, 2025 14:53
@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix failing integration tests by adding support for the gemini-3-flash-preview model and adjusting test configurations. Key changes include adding new test cases for the new model, updating token count assertions to match its behavior, and disabling some tests for freeTier configurations. Additionally, LiveSessionTests.swift has been excluded from the build.

My review focuses on improving code maintainability and ensuring test coverage isn't unnecessarily reduced. I've suggested refactoring some conditional logic in the tests to make it cleaner. I've also raised a concern about disabling an entire test file and suggested a more targeted approach if possible.

@paulb777 paulb777 marked this pull request as ready for review December 23, 2025 17:01
@paulb777 paulb777 requested a review from andrewheard December 23, 2025 17:01
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul!

@paulb777 paulb777 merged commit 688baee into main Dec 23, 2025
64 checks passed
@paulb777 paulb777 deleted the pb-green-tests-again branch December 23, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants