-
Notifications
You must be signed in to change notification settings - Fork 219
chore: enable esModuleInterop #1751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f054321
chore: enable esModuleInterop
taeold 7027996
run formatterg
taeold aa4ac1f
chore: enable esModuleInterop
taeold 3d6a04a
fix import on mocha setup script.
taeold 764f128
format
taeold d6f506a
Merge branch 'master' of https://github.com/firebase/firebase-functio…
taeold 57a4c98
Merge remote-tracking branch 'origin/next' into chore/esModuleInterop
taeold 12a2aa2
chore: update fs imports to use default imports
taeold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,6 @@ | ||
| import * as chai from "chai"; | ||
| import * as chaiAsPromisedModule from "chai-as-promised"; | ||
| import * as nockModule from "nock"; | ||
|
|
||
| // Normalize CommonJS exports so ts-node (Node.js 20) and Node.js 22's strip-only loader | ||
| // both receive callable modules without relying on esModuleInterop. | ||
| type ChaiPlugin = Parameters<typeof chai.use>[0]; | ||
| type NockModule = typeof nockModule; | ||
|
|
||
| const chaiAsPromisedExport = chaiAsPromisedModule as ChaiPlugin & { default?: ChaiPlugin }; | ||
| const chaiAsPromised = chaiAsPromisedExport.default ?? chaiAsPromisedExport; | ||
| const nockExport = nockModule as NockModule & { default?: NockModule }; | ||
| const nock = nockExport.default ?? nockExport; | ||
| import chai from "chai"; | ||
| import chaiAsPromised from "chai-as-promised"; | ||
| import nock from "nock"; | ||
|
|
||
| chai.use(chaiAsPromised); | ||
|
|
||
| nock.disableNetConnect(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,4 @@ | ||
| import * as chai from "chai"; | ||
| import * as chaiAsPromisedModule from "chai-as-promised"; | ||
|
|
||
| // Match the runtime shim in mocha/setup.ts so bin tests work on Node.js 20 ts-node | ||
| // and Node.js 22's strip-only TypeScript loader without enabling esModuleInterop. | ||
| type ChaiPlugin = Parameters<typeof chai.use>[0]; | ||
|
|
||
| const chaiAsPromisedExport = chaiAsPromisedModule as ChaiPlugin & { default?: ChaiPlugin }; | ||
| const chaiAsPromised = chaiAsPromisedExport.default ?? chaiAsPromisedExport; | ||
| import chai from "chai"; | ||
| import chaiAsPromised from "chai-as-promised"; | ||
|
|
||
| chai.use(chaiAsPromised); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.