-
Couldn't load subscription status.
- Fork 31
Add Firebase Data Connect support #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lj/fdc-support
Are you sure you want to change the base?
Conversation
9634778 to
733bd05
Compare
a2595ab to
1fc9a18
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Firebase Data Connect (FDC) function triggers, specifically for the onMutationExecuted event. It includes the necessary code to handle these triggers, define relevant data structures, and add corresponding tests. The changes involve modifications to docs/generate.sh, pyproject.toml, and the addition of new files: src/firebase_functions/dataconnect_fn.py and tests/test_dataconnect_fn.py, along with modifications to src/firebase_functions/options.py. The code appears well-structured and includes comprehensive tests. However, there are some areas where improvements can be made, particularly in error handling and code clarity.
Description
Adds basic FDC function trigger for onMutationExecuted
uv run pytestpasses locallyInternal tracking bug: b/436623435
Code sample
See go/fdc-eventarc-functions-sdk for more information