Skip to content

Conversation

@lisajian
Copy link

@lisajian lisajian commented Sep 9, 2025

Description

Adds basic FDC function trigger for onMutationExecuted

uv run pytest passes locally

Internal tracking bug: b/436623435

Code sample

from firebase_functions import dataconnect_fn

@dataconnect_fn.on_mutation_executed(
  service="service-id",
  connector="connector-id",
  operation="mutation-name"
):
def mutation_executed_handler(event: dataconnect_fn.Event):
  pass

See go/fdc-eventarc-functions-sdk for more information

@lisajian lisajian requested a review from taeold September 9, 2025 00:15
@lisajian lisajian marked this pull request as ready for review September 9, 2025 00:17
@taeold
Copy link
Collaborator

taeold commented Oct 21, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Firebase Data Connect (FDC) function triggers, specifically for the onMutationExecuted event. It includes the necessary code to handle these triggers, define relevant data structures, and add corresponding tests. The changes involve modifications to docs/generate.sh, pyproject.toml, and the addition of new files: src/firebase_functions/dataconnect_fn.py and tests/test_dataconnect_fn.py, along with modifications to src/firebase_functions/options.py. The code appears well-structured and includes comprehensive tests. However, there are some areas where improvements can be made, particularly in error handling and code clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants