-
Notifications
You must be signed in to change notification settings - Fork 124
Remove deprecated Google Mobile Ads (GMA) C++ SDK #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit removes the entire GMA C++ SDK from the Firebase C++ SDK, including all references to it across all platforms (iOS, Desktop, and Android). Changes include: - Deletion of the core `gma` directory and its contents. - Removal of GMA from CMakeLists.txt files. - Removal of GMA from Gradle build files. - Removal of GMA from iOS Podfiles. - Removal of GMA from integration tests and UI tests. - Removal of GMA from build scripts and CI workflows. - Updates to documentation (README.md, Doxyfile) to reflect the removal, while preserving release notes related to past GMA versions and adding a new note about its removal.
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit 049b2b0
Add flaky tests to go/fpl-cpp-flake-tracker |
This commit removes the explicit print statement when skipping GMA-related encrypted files in `scripts/gha/restore_secrets.py`. The script will now silently ignore these files, aligning with the complete removal of the GMA SDK and avoiding unnecessary log output.
This commit ensures that `scripts/gha/restore_secrets.py` correctly skips processing for any GMA-related encrypted files. The existing check `if api == "gma": continue` should prevent attempts to write decrypted secrets to the `gma/integration_test` directory, which no longer exists after the removal of the GMA SDK. This submission is to confirm the CI tests against this version of the script.
This commit further refines `scripts/gha/restore_secrets.py` to prevent attempts to write to the deleted `gma/integration_test` directory. Changes include: - Initializing `dest_paths` as an empty list. - More careful construction of `dest_paths` based on whether `FLAGS.artifact` is set, ensuring that GMA paths are not inadvertently created. - Explicitly continuing the loop if no valid destination path is determined for a file, preventing unnecessary decryption or write attempts. - Adding redundant checks to ensure GMA paths are not processed before file write operations as a final safeguard. This should robustly address the `FileNotFoundError` previously observed in CI.
else: | ||
# If not a google-services file or the artifact API directory doesn't exist, | ||
# skip this file for artifact processing. | ||
print(f"Skipping artifact path for {path} (API: {api}, Artifact: {FLAGS.artifact})") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (secret)
This expression logs
sensitive data (secret)
|
||
# If dest_paths is still empty (e.g., was artifact flow but conditions not met), skip. | ||
if not dest_paths: | ||
print(f"No valid destination paths determined for {path} (API: {api}). Skipping.") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (secret)
This expression logs
sensitive data (secret)
|
||
# If, after all checks, dest_paths is empty, skip. | ||
if not dest_paths: | ||
print(f"No destination paths after internal check for {path}. Skipping.") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (secret)
This expression logs
sensitive data (secret)
for dest_path_item in dest_paths: | ||
# Final explicit check, although redundant if above logic is correct. | ||
if "/gma/" in dest_path_item or "\\gma\\" in dest_path_item: | ||
print(f"CRITICAL WARNING: Attempting to write to a GMA path, this should not happen: {dest_path_item}. Skipping.") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (secret)
This expression logs
sensitive data (secret)
if "/gma/" in dest_path_item or "\\gma\\" in dest_path_item: | ||
print(f"CRITICAL WARNING: Attempting to write to a GMA path, this should not happen: {dest_path_item}. Skipping.") | ||
continue | ||
print(f"Writing decrypted file to {dest_path_item}") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (secret)
This expression logs
sensitive data (secret)
if dest_path.endswith(".plist"): | ||
_patch_reverse_id(dest_path) | ||
_patch_bundle_id(dest_path) | ||
print("Copied decrypted google service file to %s" % dest_path_item) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (secret)
This expression logs
This commit removes the entire GMA C++ SDK from the Firebase C++ SDK, including all references to it across all platforms (iOS, Desktop, and Android).
Changes include:
gma
directory and its contents.Description
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.