[Storage] Replace hardcoded SDK version with Config.OLDEST_SDK #7034
Conversation
Tests will use the Config.OLDEST_SDK instead of a hardcoded SDK if the corresponding hardcoded SDK would be below our inteded minSdk. As a pending work is re-evaluate whether these tests are necessary to keep around, or if they are irrelevant when bumping the minSdk. Related to cl/769913191
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Firebase AI Mock Responses Check
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rlazo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request standardizes the SDK version used for Robolectric tests in the Storage component. By replacing a specific hardcoded SDK version with Config.OLDEST_SDK, these tests will automatically align with our project's minimum supported SDK, making them more resilient to future updates of the minimum SDK version.
Highlights
- Standardize Test SDK Configuration: I've updated several Robolectric test classes in the Storage module to use
Config.OLDEST_SDKinstead of a hardcodedBuild.VERSION_CODES.LOLLIPOP_MR1for their@Config(sdk = ...)annotation. - Code Cleanup: Removed the now unused
import android.os.Build;statement from the affected test files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Generated by 🚫 Danger |
There was a problem hiding this comment.
Code Review
This pull request effectively replaces a hardcoded SDK version (Build.VERSION_CODES.LOLLIPOP_MR1) with Config.OLDEST_SDK in four test files. This is a good improvement for maintainability, as it centralizes the SDK configuration for these tests and makes future updates easier.
The removal of the unused android.os.Build import in each affected file is also a welcome cleanup, keeping the codebase tidy.
As noted in the pull request description, re-evaluating the necessity of these tests when the minSdk is bumped is a valuable pending task to ensure test relevance and efficiency.
Coverage Report 1Affected Products
Test Logs |
Test Results 44 files - 1 014 44 suites - 1 014 6m 17s ⏱️ - 29m 35s Results for commit 635d17d. ± Comparison against base commit f08e0c7. This pull request removes 5849 tests.♻️ This comment has been updated with latest results. |
Size Report 1Affected ProductsNo changes between base commit (f08e0c7) and merge commit (6b11667).Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
|
Friendly ping |
Tests will use the Config.OLDEST_SDK instead of a hardcoded SDK if the corresponding hardcoded SDK would be below our inteded minSdk.
As a pending work is re-evaluate whether these tests are necessary to keep around, or if they are irrelevant when bumping the minSdk.
Related to cl/769913191