Skip to content

Add RECORD_AUDIO permission check for Bidi Live API #7026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ryanwilson
Copy link
Member

Added a check for the RECORD_AUDIO permission in the AI Logic SDK for Bidi (Live API) within the LiveSession.startAudioConversation() method.

If the permission is missing, a PermissionMissingException is thrown with the message "Missing RECORD_AUDIO".

Also added unit tests to verify the new permission check behavior.

Added a check for the RECORD_AUDIO permission in the AI Logic SDK
for Bidi (Live API) within the `LiveSession.startAudioConversation()`
method.

If the permission is missing, a `PermissionMissingException` is thrown
with the message "Missing RECORD_AUDIO".

Also added unit tests to verify the new permission check behavior.
Copy link
Contributor

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.0

Copy link
Contributor

github-actions bot commented Jun 12, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 12, 2025

Copy link
Contributor

github-actions bot commented Jun 12, 2025

Test Results

0 files   -  24  0 suites   - 24   0s ⏱️ -34s
0 tests  - 102  0 ✅  - 102  0 💤 ±0  0 ❌ ±0 
0 runs   - 204  0 ✅  - 204  0 💤 ±0  0 ❌ ±0 

Results for commit 997ba6c. ± Comparison against base commit 6d166e0.

♻️ This comment has been updated with latest results.

ryanwilson and others added 4 commits June 11, 2025 21:40
I've added a check for the RECORD_AUDIO permission in the AI Logic SDK
for Bidi (Live API) within the `LiveSession.startAudioConversation()`
method.

If the permission is missing, a `PermissionMissingException` is thrown
with the message "Missing RECORD_AUDIO".

I also added unit tests to verify the new permission check behavior.

This commit includes only the source code changes for the feature
and necessary test files. Unintended modifications to Gradle build
scripts from previous troubleshooting steps have been reverted.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 12, 2025

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (f735209)Merge (7e4377d)Diff
    aar829 kB830 kB+1.24 kB (+0.1%)
    apk (aggressive)1.56 MB1.56 MB+336 B (+0.0%)
    apk (release)9.53 MB9.53 MB+760 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aof3JyCL6y.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants