-
Notifications
You must be signed in to change notification settings - Fork 410
chore: Rename the default branch to main
#3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates references to the default branch from Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the default branch name from master to main in a script and a documentation file. The changes are correct and achieve the goal of the PR. I've added a couple of suggestions to make these changes more maintainable and robust against future branch name changes.
| echo_info "---< git fetch origin main --prune --unshallow >---" | ||
| git fetch origin main --prune --unshallow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, it's a good practice to use a variable for the branch name instead of hardcoding it. This makes it easier to update in one place if the default branch name changes again in the future. You can use shell parameter expansion to provide a default value, which makes the script more robust.
| echo_info "---< git fetch origin main --prune --unshallow >---" | |
| git fetch origin main --prune --unshallow | |
| echo_info "---< git fetch origin ${DEFAULT_BRANCH:-main} --prune --unshallow >---" | |
| git fetch origin ${DEFAULT_BRANCH:-main} --prune --unshallow |
|
|
||
| Sweet, we'd love to accept your contribution! | ||
| [Open a new pull request](https://github.com/firebase/firebase-admin-node/pull/new/master) and fill | ||
| [Open a new pull request](https://github.com/firebase/firebase-admin-node/pull/new/main) and fill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this link more robust and avoid hardcoding the default branch name, you can use a URL that automatically targets the default branch for new pull requests. This prevents the need for future updates if the default branch name changes again.
| [Open a new pull request](https://github.com/firebase/firebase-admin-node/pull/new/main) and fill | |
| [Open a new pull request](https://github.com/firebase/firebase-admin-node/pull/new) and fill |
jonathanedey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Updated the default branch name to
mainwhere it was used in the scripts.If you have a local clone, you can update it by running the following commands: