storage-resize-images: prevent double trigger by honoring resizedImage flag (string or boolean) #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edImage flag as string or boolean\n\n- filters: treat metadata.resizedImage === true or "true" as already-resized\n- upload: set resizedImage metadata to string "true" for consistency\n- tests: cover boolean variant in metadata checks\n\nFixes firebase#932
|
Hi, thanks for opening this issue! I'm not sure it will fix #932 though, as the function will still be invoked? The filtering happens after the invocation within the runtime of the function. Making this more robust is still worthwhile though, we'll review this and hopefully get it out ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
storage-resize-imagesfunction could run twice for a single upload if the resized outputs re-triggered the function. This happens whenresizedImagecustom metadata is stored as a booleantruewhile the filter only checked for the string "true".Changes
metadata.resizedImage === trueor"true"as already-resized to short‑circuit early.resizedImagemetadata to string "true" for consistency with existing expectations.Why
Fixes #932.