Migrate KEDA Autoscaling from CloudWatch Metrics to SQS Queue Depth #95
+39
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates KEDA from scaling based on CloudWatch metrics to scaling directly based on SQS queue depth and closes #94.
I modified all of the files listed in the original issue, minus
helm.tf. I analyzed this file and looked at the helm charts it is releasing and did not think any changes were necessary. Please let me know if I missed something.I updated the IAM permissions for SQS and restricted them to only the queue that KEDA needs, following the principle of least privilege.
I updated documentation where necessary. I think
40_submitting_multiple_tasksmay also need an update, but I am not sure.I left the metrics lambda in place because I am not sure if it has other uses. Let me know if we want to remove it.
Note: I was not able to deploy and test this myself.
Note: We are using the
identityOwnerattribute inhpa.yaml. KEDA has deprecated this as of v2.13 and plans to remove it in v3. I have kept this as-is but it may be worth revisiting in the future.Checklist
README.md, or thedocsdirectory)area/controlplane) and kind (e.g.kind/improvement)BONUS POINTS checklist: