fix: push parsing drops commit messages unless they end in a newline

[kriswest]

resolves #971

Adjusts push parsing to not require a newline at the end commit messages in order to capture them.

Also adjusts CLI tests to clean up the rows they create, so that they can be run multiple times without the DB files needing to be reset.

[netlify]

✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name	Link
🔨 Latest commit	f7bc773
🔍 Latest deploy log	https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68383b17a58dc8000977089d
😎 Deploy Preview	https://deploy-preview-976--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.80%. Comparing base (25dbd56) to head (f7bc773).
Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
src/db/file/pushes.ts	66.66%	1 Missing and 1 partial ⚠️
src/proxy/processors/push-action/parsePush.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
+ Coverage   48.70%   53.80%   +5.09%     
==========================================
  Files          53       53              
  Lines        2166     2171       +5     
  Branches      242      244       +2     
==========================================
+ Hits         1055     1168     +113     
+ Misses       1074      952     -122     
- Partials       37       51      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kriswest]

Fixed the cypress test but am waiting on a review (in git proxy), will update monday with working cypress tests

[kriswest]

Code coverage is probably as good as I can get it - more to come on DB code coverage in #979

[kriswest]

@JamieSlome @grovesy @coopernetes This is ready for a review

[kriswest]

If I recall, the newline at the end of each commit message came in every time, so was reliably always a way of delimiting?

We had two commits, from the same developer, that came in without the terminating newline (as per example in the issue) so I suspect it boils down to whether the git client adds the newline. Unfortunately, they couldn't remember which client they used for that commit (git command line, VS code or GitHub desktop). The lack of the newline clearly doesn't break git itself so I guess it can't be relied on... As for a test... I'll have another look. At present I think parsePush is untested so we'll probably need to capture some raw data to can for the test...

[kriswest]

tests on the way - edit: tests for parsePush added

[kriswest]

Tests added based on conventional commit messages with a newline at the end.

I get zlib errors (`Error: incorrect header check') as it processes the compressed content, I suspect it always throws these. Doesn't seem to cause any issue with the parsing however...

[kriswest]

One more test coming (took me a while to find and harvest data from a commit with no newline at the end of the message)... Will push tomorrow

[kriswest]

@JamieSlome added the final test. @hemantsharma90 tracked the commits with no newline back to the IntelliJ git client. They do appear to be valid, and parse correctly after this PR.

[JamieSlome]

LGTM! 🍰