chore(OSSF): update branch protection to improve OSSF scorecard #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
|
@JamieSlome I am a fresher working in Citi and I have sent an authorization request as a Corporate Contributor for EasyCLA. Can you please approve it? |
laukik-target
suggested changes
Nov 8, 2024
There was a problem hiding this comment.
- Remove .env.development, package.json, package-lock.json
- I don't see any change related to branch protection.
Please revise your change.
@JamieSlome I think Branch Protection Settings can be updated by Maintainers only as we do not have access to update the settings.
JamieSlome
reviewed
Nov 8, 2024
JamieSlome
reviewed
Nov 8, 2024
I am participating in Citi hackathon, so is it fine to contribute as an individual instead of Corporate Contributor ? I guess for those who take part in hackathon needs authorization request as a Corporate Contributor, am i right ? |
Have the service report back the proxyURL for each project, rather than being embedded inside the frontend bundle. Concequence is duplicating some data but very minor and allows for us to serve different projects from different proxies in the future. Removed unused vite env var, added method to pull service's current path and substitute in the http proxy port. Works for local dev, should maintain current behaviour. Custom domain can be applied via optional config. New config value added to the config schema. Config schema documentation has been regenerated (including some other absent items).
This commit modifies the directory creation permissions in the pullRemote function of pullRemote.js. Previously, the function was setting directory permissions to 0777 (full read, write, and execute permissions for user, group, and others). This approach is not aligned with best practices for security, particularly in secure environments such as OpenShift, where overly permissive settings can lead to vulnerabilities. The updated code now sets the permissions to 0755 (read, write, and execute for the user; read and execute for group and others). This change enhances security by restricting write access to the owner only while still allowing necessary read and execute permissions.
Sabarivasan-Velayutham
force-pushed
the
bump-ossf
branch
from
ebbaaf6
to
368967f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Bump OSSF Score Above 9.0 ⬆️
This pull request focuses on improving the security configuration of our repository to enhance our OSSF Scorecard rating above 9.0. This involved changes in protections and access token usage.
Changes Implemented
mainbranch to strengthen security, which includes:main.main..githubfolder to enforce code ownership and ensure critical files receive proper review before merging.repo,read:organdread:discussionscopes. Fine-grained tokens may not provide the required permissions.Benefits
Checklist
main.CODEOWNERSfile to enforce ownership and improve scorecard evaluation.