Lionel Smith-Gordon Use of Asset in AssetCriteria #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from AssetIdentifier to Asset itself
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AssetCriteria documentation update
|
Reviewed in the Collateral Working Group on 29 October 2024, see #3169. |
ListingType cardinality
chrisisla
previously approved these changes
Nov 8, 2024
| @@ -220,13 +220,13 @@ type AssetCriteria: | |||
| agencyRating AgencyRatingCriteria (0..*) | |||
| maturityType MaturityTypeEnum (0..1) | |||
| maturityRange PeriodRange (0..1) | |||
| assetIdentifier AssetIdentifier (0..*) | |||
| specificAssets Asset (0..*) | |||
There was a problem hiding this comment.
The design principles impose a singular naming convention even when we are expecting lists of data i.e. specificAsset should be used here. I think adding the 's' on the end makes more sense in this instance.
valdensmith
reviewed
Nov 8, 2024
valdensmith
reviewed
Nov 8, 2024
valdensmith
reviewed
Nov 8, 2024
valdensmith
previously approved these changes
Nov 8, 2024
Typo fixed and description enhanced |
|
Something needs to be added to line 184 too for this
Vernon Alden-Smith
Director - Collateral Initiatives
ISDA
From: Lionel SG ***@***.***>
Sent: Friday, November 8, 2024 10:20 AM
To: finos/common-domain-model ***@***.***>
Cc: Vernon AldenSmith ***@***.***>; Review requested ***@***.***>
Subject: Re: [finos/common-domain-model] Lionel Smith-Gordon Use of Asset in AssetCriteria (PR #3228)
EXTERNAL EMAIL
Same description is it also worth adding the details that this attribute can be used for specific source ids such as ISINS/ CUSIPS Typo fixed and description enhanced —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review
[Image removed by sender.]<https://report.mimecastcybergraph.com/?magiclink=https%3A%2F%2Fapi.services.mimecast.com%2Foauth2%2Fauthorize%3Fresponse_type%3Dcode%26client_id%3Do20nRkVXf7VUVnANkXhoOwGytEwGN0YAlyeDJn7oBTGNl2kN%26state%3DeyJhbGciOiJSU0EtT0FFUC0yNTYiLCJlbmMiOiJBMjU2R0NNIn0.Zfg_IGVYTImoubAlBbZi03RMQ9EvP_y6u9r1BgkNDbQB2fCB7i97MK4tTLnRF1h7kW0znZUxqQiKE2R0Pzmp3MIZ-eX2R5NUcFmjznM8F9ax_DOD0pg7VnNy-E4rsDbt2b_yymXYixzAC0pYMSUDBYaBN7wQgUPO6tbWsTVmKoVLc-AnTVS1p8KYfYM7DWoEGSjvzZh0LSmnn7eJHpL_6deH6UopLY18_J6SnEdTxJyszLBbWefXUFSeQBimIY2noaY9WwfujWt4RxRavB6ktfihA7Mnt4-wyljL0N96z9N9G8d4Cr2CSDCugEgX4S6Jb57-quk2ItoQNhTIHM2NQg.TlOq44bgXg7rpTwV.Q57_nlVjBbYcx6DY29zP_Db9FdLMso7fAqUL8-vIl0xRp4nUdUdnO7UKab3y2bfEERMkxkPwj1CyZi0Lt37zwzQe2e2ZfqJxd-mlLDeEhhZ1u9QEtvIQdzlL4_EztQOcaI4ju6nbB4BbspMb_Pp2RrcwhoB3zXF6zttrZ4UhvqgQcKlK-wz5waItpg5p7d-AiRe6o9rwsvziMdmS8oykSF-yu7EsNCzRnEAMNdaPn5U7yO8nIB0NrC9zK3bWkepO2uG-tTQE9yBpV6O5JCMWMFvKEripw7GPQwJtkjnTuSGKSHroMDrY4kYdWIj4WJC9c3Remjy2ME-7rEzRxoqLw4wsFLtChKm7Ms49JCvQxLfgRoH2ESMDSrLUVmCo75dZPbwXj-TUVXhgw-AS5Y0Z8-8U3OvySaHG5kVVEQ9ngz9rYOHjCaMkqxwAH2f8ZxmDjDcpGETCYABf9sA2fFe6UpeBmPGa_rJK5j40AXAqbwTLOAOeJOtxzzZVt-AmKaAo9IZjJBingLWGa1aYQLH0wclNTTYbYD84w5dvC0gtEEbEtzZc5ZQxRO2TtAwSu8tFeMjaocqEcxrqqhu4AzHLVRbtpKn56PBVV3BtBKpiUmvFT_6mwJBpiua4SEndMhELZqCOQNluNrJhk4lCqdRXhxjNPXd0eqLOwSV2gKMKivfBgky11HU9O0LdrcUarLF4e0GPDQnZLMzFgZvI0mVP-hfglFdCRNFQGB6WsB_SaMaf2OzfX5f9hOUAJodDjTz1-KrzeYMibYSChZtIXu8LCTohdLy93GTgakh5t8zNIQWbCceZAT80n1bHPhYXBnXO9X2lfN3I3XkDJCqK9tlkhjy3b2C_khfWm-hi74KJqv2hGiYnal4_ANZGmeCU.a4414tXuI1FtQyObcIWVPw%26redirect_uri%3Dhttps%3A%2F%2Freport.mimecastcybergraph.com%2Fcallback>
CGBANNERINDICATOR
Same description is it also worth adding the details that this attribute can be used for specific source ids such as ISINS/ CUSIPS
Typo fixed and description enhanced
—
Reply to this email directly, view it on GitHub<#3228 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATGKR7OY5D522DW6WYWK4L3Z7SF4TAVCNFSM6AAAAABRLK43QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRUGMZDKNRYHA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
The information contained in either this email and, if applicable, the attachment, are confidential and are intended only for the recipient. The contents of either the email or the attachment may not be disclosed or used by anyone other than the addressee. If you are not the intended recipient(s), any use, disclosure, copying, or distribution is prohibited and may be unlawful. If you have received this communication in error, please notify us by e-mail at ***@***.******@***.***> then delete the e-mail and all attachments and any copies thereof.
|
valdensmith
previously approved these changes
Nov 8, 2024
hugohills-regnosys
approved these changes
Nov 11, 2024
hugohills-regnosys
deleted the
lionel_auth0_65080e6e10b98cc73ac44ca1-AssetCriteria
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.