Skip to content

Feature/issue 177 enhanced config screens - #238

Open
kallal79 wants to merge 4 commits into
finos:mainfrom
kallal79:feature/issue-177-enhanced-config-screens
Open

kallal79 wants to merge 4 commits into
finos:mainfrom
kallal79:feature/issue-177-enhanced-config-screens

Conversation

@kallal79

@kallal79 kallal79 commented Mar 29, 2026 •

Copy link
Copy Markdown
Contributor

relates to #177

Before: Basic text-only config with hardcoded icons/screenshots.
After: Professional interface with drag-and-drop uploads, validation, and rich metadata.

@SeeWhatsOn SeeWhatsOn mentioned this pull request Mar 30, 2026
23 of 26 tasks
@robmoffat

Copy link
Copy Markdown
Member

@SeeWhatsOn I had a go at running this but I get lots of build errors. A lot of the ones I had to fix in #234 already

I think we should leave this for now until we can get that merged or the build fixed.

@robmoffat

Copy link
Copy Markdown
Member

@kallal79 thanks for this contribution! Looking forward to testing it out!

@kallal79

Copy link
Copy Markdown
Contributor Author

Thanks @robmoffat @SeeWhatsOn .. — I’ll wait for #234 to merge...

@kriswest

Copy link
Copy Markdown
Contributor

Needs a rebase against main to resolve conflicts/diff. Also likely to conflict with new UI due in 3.0 - but can be kept open to try and merge against that when raised. Converting to draft for the time being

@kriswest
kriswest marked this pull request as draft July 20, 2026 13:50
@kallal79
kallal79 marked this pull request as ready for review July 26, 2026 15:30
@kallal79
kallal79 force-pushed the feature/issue-177-enhanced-config-screens branch from bcf2217 to 902bbee Compare July 26, 2026 15:33
Comment thread scripts/fix-fdc3-imports.js Fixed
@kallal79
kallal79 force-pushed the feature/issue-177-enhanced-config-screens branch from 66c5e1e to 886ea1c Compare October 15, 2026 19:26
@kallal79

Copy link
Copy Markdown
Contributor Author

Hi @kriswest @robmoffat @SeeWhatsOn,

I have rebased this branch onto the latest main branch and resolved all conflicts and CI issues:

  1. Rebase & Merge Conflicts: Cleanly rebased against latest main (incorporating Sail security demo #234 and FDC3 3.0 + 2.2 Conformance Passing #378 / FDC3 3.0 compatibility merges). Resolved all conflicts in package-lock.json, packages/da-impl/test/step-definitions/generic.steps.ts, and packages/web/package.json.
  2. CodeQL Alert Resolved: Removed legacy test/import workaround scripts (scripts/fix-fdc3-imports.js and scripts/create-fdc3-testing.js), eliminating the CodeQL file system race condition security alert.
  3. Workflow & CVE Scanning: Synchronized with upstream's updated .github/workflows/cve-scanning.yml using OSV-Scanner.
  4. Linting & Code Style:
    • Updated ESLint config to properly handle test suites with projectService.
    • Fixed unused variable in RemoteSocketService.ts.
    • Updated .prettierignore for build artifacts; npm run format:check and npm run lint now pass cleanly.
  5. Build Verification: Verified npm run build succeeds cleanly across all packages (@finos/fdc3-sail-da-impl, @finos/fdc3-sail-common, and @finos/fdc3-sail-web).

All CI checks (lint-format-build, CodeQL, Semgrep) are now passing green, and the PR is ready for review and testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants