feat: 채팅방 목록/상세정보 응답에 탈퇴 회원 식별 컬럼 추가#486
Merged
Merged
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces logic to handle withdrawn users in chat rooms by masking their personal information and adding a 'withdrawn' status flag to the response DTOs. It also refactors the ChatRoomConverter to centralize DTO construction and optimizes the BlockService by utilizing ID-based repository checks to avoid unnecessary entity lookups. Review feedback suggests using descriptive placeholders for withdrawn users' nicknames instead of null to improve the client-side experience and recommends preserving the actual block status for withdrawn users rather than hardcoding it to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 관련 이슈
🛠️ 작업 내용
USER_NOT_FOUND(404)가 발생해 채팅 상세 조회가 불가능하던 문제 수정.📢 참고 및 특이사항
BlockService.isBlocked가 양쪽 user를findActiveById로 로드하면서 차단 관계 확인뿐 아니라 사용자 활성 검증까지 책임지고 있었음.findActiveById두 번 호출하던 부분 제거existsByBlocker_IdAndBlocked_Id(Long, Long)를 추가해 ID 기반 exists 쿼리 한 번으로 차단 관계만 확인✅ 체크리스트
feat: 로그인 기능 구현)close #이슈번호)