chore: update lotus to v1.32.0-rc3 #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Terryhung
commented
Mar 21, 2025
•
Terryhung
commented
Terryhung
force-pushed
the
terryhung/update-lotus-v1.32.0-rc3
branch
from
9784acf to
f402b45
Compare
rvagg
reviewed
Mar 24, 2025
Comment on lines
231
to
239
| expectedReward := big.Mul(sector.ExpectedDayReward, big.NewInt(int64(cappedSectorAge))) | ||
| expectedReward := big.Mul(*sector.ExpectedDayReward, big.NewInt(int64(cappedSectorAge))) | ||
| // relevant_replaced_age = min(PowerBaseEpoch - Activation, lifetimeCap - cappedSectorAge) | ||
| relevantReplacedAge := big.NewInt(int64(min(sector.PowerBaseEpoch-sector.Activation, lifetimeCap-cappedSectorAge))) | ||
| // Add the replaced sector's contribution. | ||
| expectedReward = big.Add(expectedReward, big.Mul(sector.ReplacedDayReward, relevantReplacedAge)) | ||
| expectedReward = big.Add(expectedReward, big.Mul(*sector.ReplacedDayReward, relevantReplacedAge)) | ||
| // penalized_reward = expected_reward / TERMINATION_REWARD_FACTOR_DENOM | ||
| penalizedReward := big.Div(expectedReward, big.NewInt(int64(TERMINATION_REWARD_FACTOR_DENOM))) | ||
| // Termination fee = ExpectedStoragePledge + (penalized_reward / EPOCHS_IN_DAY) | ||
| return big.Add(sector.ExpectedStoragePledge, big.Div(penalizedReward, big.NewInt(int64(EPOCHS_IN_DAY)))) | ||
| return big.Add(*sector.ExpectedStoragePledge, big.Div(penalizedReward, big.NewInt(int64(EPOCHS_IN_DAY)))) |
There was a problem hiding this comment.
beware that these are going to start being nil from nv25 so you should be careful to guard for them
But also, maybe this should be replaced with a go-state-types variation of this since termination fees have been "simplified" and have a different calculation now. See filecoin-project/go-state-types#376 for some exposed methods that help with this; filecoin-project/lotus#12968 has use of them but also exposes them through the lotus go-state-types abstractions which might be more helpful. See the itest in there for how it can be used (a couple of variations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.