Skip to content

chore(bigint): write with Writer for fewer allocations #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 12, 2025

Parking-lot for now because I had this on a local branch and think it makes a slight difference in allocations. Probably needs some verifications though!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 3.40%. Comparing base (d1b1091) to head (ab15a64).

Files with missing lines Patch % Lines
big/int.go 53.84% 11 Missing and 7 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage    3.39%    3.40%           
=======================================
  Files         663      663           
  Lines      178011   178044   +33     
=======================================
+ Hits         6041     6056   +15     
- Misses     170121   170134   +13     
- Partials     1849     1854    +5     
Files with missing lines Coverage Δ
big/int.go 63.00% <53.84%> (-2.72%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📌 Triage
Development

Successfully merging this pull request may close these issues.

2 participants