[FIL-758] Allow to close ane reopen application #269
Conversation
fplus-http-server/src/main.rs
Outdated
| .service(router::application::allocation_failed), | ||
| .service(router::application::allocation_failed) | ||
| .service(router::application::decline) | ||
| .service(router::application::reopen_decline_application), |
There was a problem hiding this comment.
| .service(router::application::reopen_decline_application), | |
| .service(router::application::reopen_declined_application), |
There was a problem hiding this comment.
Applies to all reopen_decline_application functions
| @@ -272,6 +272,7 @@ pub enum AppState { | |||
| StartSignDatacap, | |||
| Granted, | |||
| TotalDatacapReached, | |||
| DeclineApplication, | |||
There was a problem hiding this comment.
| DeclineApplication, | |
| Declined, |
Decline is a verb, we want an adjective here.
No need to add Application in variant name, when this entire type already is called AppState, so it's obvious it's about an application
| @@ -14,6 +14,7 @@ impl AppState { | |||
| AppState::StartSignDatacap => "start sign datacap", | |||
| AppState::Granted => "granted", | |||
| AppState::TotalDatacapReached => "total datacap reached", | |||
| AppState::DeclineApplication => "decline application", | |||
There was a problem hiding this comment.
| AppState::DeclineApplication => "decline application", | |
| AppState::DeclineApplication => "declined", |
| pub fn close_application(self) -> Self { | ||
| LifeCycle { | ||
| state: AppState::DeclineApplication, |
There was a problem hiding this comment.
Declined specifically means that someone reviewed the application and rejected it on some grounds. Closing application is a more generic term, that could also apply in cases like client withdrawing the application or reaching the total requested datacap.
In fact, close_application is called when total datacap is reached - setting the state to Declined in such case is very confusing. It should be a separate state (or even just leave it as Granted, just mark as inactive?)
Filip-L
force-pushed
the
FIL-758-allow-to-close-and-reopen-application
branch
from
3eeb8ad to
c9076c8
Compare
No description provided.