fix: pp init in PDPV0 #661
Conversation
LexLuthr
requested review from
rvagg and
ZenGround0
and removed request for
a team
| return false, xerrors.Errorf("failed to send transaction: %w", err) | ||
| } | ||
|
|
||
| txHashLower := strings.ToLower(txHash.Hex()) |
There was a problem hiding this comment.
I am not a gopher, but some quick snooping through source seems to show that txHash.Hex() should always produce lowercase hex strings?
txHash.Hex() definition seems to be here:
which uses go-ethereum hex util:
which uses encoding/hex stdlib's Encode, which should only ever produce lowercase based on the hextable="0123456789abcdef"? https://cs.opensource.google/go/go/+/refs/tags/go1.23.2:src/encoding/hex/hex.go;l=17
There was a problem hiding this comment.
I had the same understanding but I remember that DB was complaining about serialization. This lead to basically ppInit never properly working. Curio keept spawning new ppInit tasks. If that is not the case anymore with the pdpv0 branch then feel free to close this. I don't have the error handy.
There was a problem hiding this comment.
It seems we were focusing on different things. Actual fix is .Hex(). strings.ToLower() is there only due to historical context. Perhaps, we can clean that up in other places as well later.
This should fix issue with ppInit failing continuously.