-
Notifications
You must be signed in to change notification settings - Fork 31
correct secondary ui server spec #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ship some default or document them. The cors in market http server are meant to allow serving static websites on PDP. We should let users decided what degree of risk they are okay with but we must either ship or document good default.
Also, do we want to share the CORS between UI and Market server since they are meant to serve different things?
@LexLuthr Can you look into this? |
Seems to be working for me and in CI. Do you have swag command installed? Maybe Go clean cache? |
Changes I will make today:
|
This allows limiting secondary servers to a specific list