Skip to content

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Sep 24, 2025

This allows limiting secondary servers to a specific list

@snadrus snadrus requested a review from a team as a code owner September 24, 2025 22:00
@snadrus snadrus marked this pull request as draft September 25, 2025 04:49
@snadrus snadrus self-assigned this Sep 25, 2025
@snadrus snadrus marked this pull request as ready for review September 25, 2025 05:00
@snadrus snadrus requested review from Reiers and LexLuthr September 25, 2025 05:01
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ship some default or document them. The cors in market http server are meant to allow serving static websites on PDP. We should let users decided what degree of risk they are okay with but we must either ship or document good default.

Also, do we want to share the CORS between UI and Market server since they are meant to serve different things?

@snadrus
Copy link
Contributor Author

snadrus commented Sep 25, 2025

make marketgen is broken:
2025/09/25 11:30:37 create swagger.yaml at market/mk20/http/swagger.yaml
/Library/Developer/CommandLineTools/usr/bin/make -C extern/filecoin-ffi/ .install-filcrypto
go clean -cache -testcache
go: unlinkat /Users/andy/Library/Caches/go-build/c5: directory not empty
make[1]: *** [.install-filcrypto] Error 1
make: *** [build/.filecoin-install] Error 2

@LexLuthr Can you look into this?

@LexLuthr
Copy link
Contributor

make marketgen is broken: 2025/09/25 11:30:37 create swagger.yaml at market/mk20/http/swagger.yaml /Library/Developer/CommandLineTools/usr/bin/make -C extern/filecoin-ffi/ .install-filcrypto go clean -cache -testcache go: unlinkat /Users/andy/Library/Caches/go-build/c5: directory not empty make[1]: *** [.install-filcrypto] Error 1 make: *** [build/.filecoin-install] Error 2

@LexLuthr Can you look into this?

Seems to be working for me and in CI. Do you have swag command installed? Maybe Go clean cache?

@snadrus
Copy link
Contributor Author

snadrus commented Sep 26, 2025

Changes I will make today:

  1. better docs: "*" allows everyone, it's best to specify the UI server's hostname.
  2. rm from market server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants