-
Notifications
You must be signed in to change notification settings - Fork 31
docs: revise Enable PDP documentation for clarity and detail #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated the Enable PDP documentation to provide a comprehensive guide on setting up a PDP-enabled Filecoin Storage Provider using Lotus, YugabyteDB, and Curio. Enhanced clarity on prerequisites, installation steps, and configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great write up. 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some minor changes
|
||
🧠 Curio uses YugabyteDB to store metadata about deals, sealing operations, and PDP submissions. | ||
|
||
<table data-view="cards"><thead><tr><th></th><th data-hidden></th><th data-hidden data-card-cover data-type="image">Cover image</th><th data-hidden data-card-target data-type="content-ref"></th></tr></thead><tbody><tr><td>Yugabyte Documentation</td><td><a href="https://docs.yugabyte.com/preview/tutorials/quick-start/linux/">https://docs.yugabyte.com/preview/tutorials/quick-start/linux/</a></td><td><a href="../../.gitbook/assets/yugabyte.svg">yugabyte.svg</a></td><td><a href="https://docs.yugabyte.com/preview/tutorials/quick-start/linux/">https://docs.yugabyte.com/preview/tutorials/quick-start/linux/</a></td></tr><tr><td>Yugabyte Support Channels</td><td><a href="https://filecoinproject.slack.com/archives/C06LF5YP8S3">Filecoin Slack - #fil-curio-help</a> - <a href="https://inviter.co/yugabytedb">Yugabyte Slack</a></td><td><a href="../../.gitbook/assets/Curio_placeholder.webp">Curio_placeholder.webp</a></td><td><a href="https://filecoinproject.slack.com/archives/C06LF5YP8S3">https://filecoinproject.slack.com/archives/C06LF5YP8S3</a></td></tr></tbody></table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not rendered correctly. Please check test deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing any rendering issues with this. Can you be more specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using https://filoz.gitbook.io/filoz-filecoin-docs/storage-providers/pdp/install-and-run-pdp to review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Why would I? I am review content only in Curio docs. You need to add those logos to Curio docs under assets. This explains why you can render them and no one else can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting my gitbooks confused 😉
Should be good now @LexLuthr 👍
🧠 This section enables **FWSS Proof of Data Possession (PDP)** on your SP node using Curio. These steps guide you through running a standalone PDP service using Curio and pdptool. | ||
|
||
### Connect to service | ||
<table data-view="cards"><thead><tr><th></th><th data-hidden data-card-cover data-type="image">Cover image</th><th data-hidden data-card-target data-type="content-ref"></th></tr></thead><tbody><tr><td>PDP Support Channels</td><td><a href="../../.gitbook/assets/Filecoin.svg.png">Filecoin.svg.png</a></td><td><a href="https://filecoinproject.slack.com/archives/C0717TGU7V2">https://filecoinproject.slack.com/archives/C0717TGU7V2</a></td></tr></tbody></table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not rendered correctly either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, not seeing any rendering issues with this. What are you seeing, buddy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give me your render URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review site is https://filoz.gitbook.io/filoz-filecoin-docs/storage-providers/pdp/install-and-run-pdp
Image URL is: https://filoz.gitbook.io/filoz-filecoin-docs/~gitbook/image?url=https%3A%2F%2F792497867-files.gitbook.io%2F%7E%2Ffiles%2Fv0%2Fb%2Fgitbook-x-prod.appspot.com%2Fo%2Fspaces%252FmhuAQmD1M6qQ3TeHXCgu%252Fuploads%252Fgit-blob-556b1da4242b6018067b30ecb463cc7166a08180%252FFilecoin.svg.png%3Falt%3Dmedia&width=490&dpr=4&quality=100&sign=8ca6a921&sv=2
Co-authored-by: LexLuthr <[email protected]>
- Add lotus-logo-big.png for Lotus documentation card - Add Filecoin.svg.png for Filecoin/support channel cards - Add yugabyte.svg for YugabyteDB documentation card - Add Curio_placeholder.webp for Curio documentation cards These images fix the broken cover images that were being incorrectly rendered from external sources.
Update all image references from ../../.gitbook/assets/ to ../.gitbook/assets/ to correctly point to where the images are actually located (/documentation/en/.gitbook/assets/)
It looks like the CI error is unrelated to the changes made @LexLuthr. Are we able to re-run the failed tasks and merge this to the docs? Thanks, buddy 🙏 |
Updated the Enable PDP documentation to provide a comprehensive guide on setting up a PDP-enabled Filecoin Storage Provider using Lotus, YugabyteDB, and Curio. Enhanced clarity on prerequisites, installation steps, and configurations.