Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Move ku to ckb with complete translation #7837

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

AlanD20
Copy link
Contributor

@AlanD20 AlanD20 commented Aug 17, 2023

  • Changes have been thoroughly tested to not break existing functionality.

Hey there!

This PR moves existing ku translation to ckb that includes full complete Central Kurdish translation.

Why?
The Kurdish language has a variety of dialects, leading to inconsistencies in many packages. The ku locale, for instance, might represent Central Kurdish translation in one package, but in another package, it could be Northern or Southern Kurdish. These dialect differences are significant and could result in unintentional selection of the locale.

Therefore, this pull request proposes a consistent CLDR locale code by moving the existing ku locale to ckb locale, which represents Central Kurdish translation, into its own designated locale code.

Some packages support ckb for Central Kurdish translation such as Carbon which is very intuitive to easily sync the translation once it's changed within Laravel's locale, but unfortunately some JS packages haven't merged the already opened migration from ku to ckb locale for Central Kurdish translations. Therefore, this PR will use the existing ku translation in dayjs and exports it as ckb translation. If in the future these locales merged successfully, we can also update the locale packages for Filament as well.

After FilePond merges ckb locale, we can also update supported locales in Filament.

Thank you!

References:

@danharrin
Copy link
Member

Is this a breaking change for people currently using ku though?

@danharrin danharrin self-assigned this Aug 17, 2023
@danharrin danharrin added the i18n label Aug 17, 2023
@danharrin danharrin added this to the v3 milestone Aug 17, 2023
@danharrin
Copy link
Member

I think so, so we probably need to copy the translations over rather than move them completely

@AlanD20
Copy link
Contributor Author

AlanD20 commented Aug 17, 2023

Yes. One possible solution we could do is that, we have to sync both ku and ckb translations, till someone else in the future reserves ku locale to another Kurdish translation dialect.

Another thing is that, I'm not sure what ku locale is actually reserved for since if we follow ISO 639-3 for consistency, each Kurdish dialect has its own identifier.

ISO 639-3 - ckb -> Central Kurdish
ISO 639-3 - kmr -> Northern Kurdish
ISO 639-3 - sdh -> Southern Kurdish

Let me know if we should copy the entire ckb translation to ku translation for the purpose of not breaking existing translation.

@danharrin
Copy link
Member

Yes please, they need to be kept in sync until further notice

@AlanD20
Copy link
Contributor Author

AlanD20 commented Aug 17, 2023

Done. Thank you!

@danharrin danharrin merged commit 67c0366 into filamentphp:3.x Aug 17, 2023
4 checks passed
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants