Skip to content

⚡ Optimize logic_and Cartesian product computation #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffalcinelli merged 1 commit into from
Jun 18, 2026
Merged

⚡ Optimize logic_and Cartesian product computation #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions pydivert/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,7 @@ def logic_and(self, children):
for child in children:
if not isinstance(child, list) or not child:
continue # pragma: no cover
new_result = []
for existing_rule in result_rules:
for new_rule_part in child:
merged = existing_rule.copy()
merged.update(new_rule_part)
new_result.append(merged)
result_rules = new_result
result_rules = [existing | new for existing in result_rules for new in child]
return result_rules

def logic_or(self, children):
Expand Down