🔒 Fix potential XSS via Unsanitized URL Attributes - #67
Conversation
Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
🎯 What: Fixed a potential Cross-Site Scripting (XSS) vulnerability by sanitizing
⚠️ Risk: A malicious
client.baseUrl,pageRedirectUri, andactionUriinerror.ftlandinfo.ftl.javascript:ordata:URI injected into the URL variables could execute unauthorized scripts when a user clicks the links.🛡️ Solution: Implemented a robust blacklist validation
!url?trim?lower_case?starts_with("javascript:") && !url?trim?lower_case?starts_with("data:") && !url?trim?lower_case?starts_with("vbscript:")before rendering thehrefattribute. This neutralizes malicious payloads while still allowing safe custom schemes (likemyapp://callback) used by native mobile applications.PR created automatically by Jules for task 12205455578476273070 started by @ffalcinelli