Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 26, 2025

Description

Refs https://github.com/fern-demo/auth0-java-sdk/pull/63

Fixes the Java SDK's StreamTestGenerator to use Java 8 compatible constructs instead of Java 9+ features (List.of() and Map.of()). This was causing issues in customer SDKs targeting Java 8.

Changes Made

  • Replaced List.of() with Arrays.asList() for creating immutable lists
  • Replaced Map.of() with a new createMap() helper method using HashMap
  • Added proper generics (List<Map<String, String>>, List<String>) instead of raw types
  • Used new ArrayList<>() wrapper for the mutable list case in testSseStreamWithTerminator
  • Added createCreateMapHelperMethod() to generate the helper
  • Added versions.yml entry for version 3.20.1

Testing

  • Lint checks pass (pnpm run check)
  • Spotless formatting applied (./gradlew spotlessApply)
  • Seed tests regenerated via CI

Human Review Checklist

  • Verify the generated StreamTest.java will compile with Java 8
  • Confirm seed test updates look correct after CI regenerates them
  • Check that createMap helper method signature is correct (note: only supports single key-value pairs, which matches current test usage)

Link to Devin run: https://app.devin.ai/sessions/06daac14c2614877aec913b24cb9de6d
Requested by: [email protected] (@tstanmay13)

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@tstanmay13 tstanmay13 enabled auto-merge (squash) November 27, 2025 05:09
@tstanmay13 tstanmay13 merged commit 7c67f6f into main Nov 27, 2025
127 checks passed
@tstanmay13 tstanmay13 deleted the devin/1764186743-fix-java-stream-test-java8-compat branch November 27, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants