-
Notifications
You must be signed in to change notification settings - Fork 269
feat(csharp): add withRawResponse() support #10908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
14
commits into
main
Choose a base branch
from
devin/1764179947-csharp-with-raw-response
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(csharp): add withRawResponse() support #10908
devin-ai-integration
wants to merge
14
commits into
main
from
devin/1764179947-csharp-with-raw-response
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to access raw HTTP response data (status code, headers) when making API calls in the C# SDK. Changes: - Add RawResponse<T> template class with Body, StatusCode, and Headers properties - Create RawSubPackageClientGenerator and RawRootClientGenerator for raw client classes - Add WithRawResponse property to client classes that returns raw client instance - Modify HttpEndpointGenerator to generate raw response methods - Register RawResponse in AsIs.ts and add type references in generation-info.ts Co-Authored-By: [email protected] <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Main client methods now delegate to raw client and call .Body, matching the Java pattern where rawClient has the HTTP implementation and main client is a thin wrapper. Co-Authored-By: [email protected] <[email protected]>
For endpoints without a response body, don't try to access .Body since it doesn't exist. Just await the raw call without returning. Co-Authored-By: [email protected] <[email protected]>
… on main client Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Slack request from @tjb9dc
Adds the ability to access raw HTTP response data (status code, headers) when making API calls in the C# SDK, similar to the TypeScript implementation.
Link to Devin run: https://app.devin.ai/sessions/10231e3101304c52917326b69a8fdab9
Requested by: [email protected] (@tjb9dc)
Changes Made
RawResponse<T>template class withBody,StatusCode, andHeaderspropertiesRawSubPackageClientGeneratorandRawRootClientGeneratorfor generating raw client classesWithRawResponseproperty to client classes that returns the raw client instanceHttpEndpointGeneratorto generate raw response methods whengenerateRawResponse: trueRawResponseinAsIs.tsand added type references ingeneration-info.tsUpdates Since Last Revision
this.System.NotSupportedExceptionwiththis.Types.BaseExceptionfor unsupported endpoint typesgenerateRawResponseparameter propagation throughEndpointGenerator.tsversions.yml(version 2.10.0 - minor bump required forfeattype)RawResponse<HttpResponseHeaders>instead ofRawResponse<object>(caught byhttp-headseed test)Testing
Human Review Checklist
Seed tests not updated - No seed test fixtures were updated to validate the generated C# code compiles. CI passed using existing fixtures.
Streaming endpoints throw BaseException - Raw response wrapper is not supported for streaming, streamParameter, and bytes endpoints. These will throw
BaseExceptionat runtime. Is this acceptable?Pagination not supported - Raw response methods use unpaged endpoint signature, so paginated endpoints may not work correctly with
WithRawResponse.Template design - Review
RawResponse.Template.cs- usesintfor StatusCode (notHttpStatusCodeenum) andHttpResponseHeadersfor headers.