RTBH/lab follow-up fixes: upgrade self-heal + pidfile identity#83
Merged
Conversation
…): verify bird identity before kill (#81)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80, closes #81 — two small, correct fixes from the C1c review backlog.
RtbhManager::apply_addlogged a journal-write failure without queuing a retry, leaving the mirror row's origin stale (auto) after a transient DB blip. It now routes the failure throughqueue_mirror(Announce { origin: Manual }), so the next tick heals it as Manual. Regression-tested (manual_upgrade_journal_failure_self_heals_as_manual).kill_pidfilesverifies process identity. Teardown now reads/proc/<pid>/command onlySIGKILLs if it'sbird, so a recycled/dead PID is skipped (PID-reuse race).The two larger backlog items — #79 (BGP session-task supervision) and #82 (BGP transport security, TCP-MD5/GTSM) — remain tracked for later.
Verified:
DATABASE_URL=… cargo test --workspace,cargo fmt --all --check,cargo clippy --workspace --all-targets -- --deny warnings,bash scripts/coverage.shall green.🤖 Generated with Claude Code