Skip to content

RTBH/lab follow-up fixes: upgrade self-heal + pidfile identity#83

Merged
vxfemboy merged 1 commit into
mainfrom
sp-c-m1c-followups2
Jul 2, 2026
Merged

RTBH/lab follow-up fixes: upgrade self-heal + pidfile identity#83
vxfemboy merged 1 commit into
mainfrom
sp-c-m1c-followups2

Conversation

@vxfemboy

@vxfemboy vxfemboy commented Jul 2, 2026

Copy link
Copy Markdown
Member

Closes #80, closes #81 — two small, correct fixes from the C1c review backlog.

  • RTBH: mirror self-heal misses the Auto->Manual upgrade journal write #80 — RTBH mirror self-heal covers the Auto→Manual upgrade. The upgrade path in RtbhManager::apply_add logged a journal-write failure without queuing a retry, leaving the mirror row's origin stale (auto) after a transient DB blip. It now routes the failure through queue_mirror(Announce { origin: Manual }), so the next tick heals it as Manual. Regression-tested (manual_upgrade_journal_failure_self_heals_as_manual).
  • lab: kill_pidfiles should verify process identity (PID-reuse race) #81 — lab kill_pidfiles verifies process identity. Teardown now reads /proc/<pid>/comm and only SIGKILLs if it's bird, so a recycled/dead PID is skipped (PID-reuse race).

The two larger backlog items — #79 (BGP session-task supervision) and #82 (BGP transport security, TCP-MD5/GTSM) — remain tracked for later.

Verified: DATABASE_URL=… cargo test --workspace, cargo fmt --all --check, cargo clippy --workspace --all-targets -- --deny warnings, bash scripts/coverage.sh all green.

🤖 Generated with Claude Code

@github-project-automation github-project-automation Bot moved this to Backlog in blackwall Jul 2, 2026
@vxfemboy vxfemboy merged commit 9501250 into main Jul 2, 2026
2 checks passed
@vxfemboy vxfemboy deleted the sp-c-m1c-followups2 branch July 2, 2026 19:54
@github-project-automation github-project-automation Bot moved this from Backlog to Done in blackwall Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

lab: kill_pidfiles should verify process identity (PID-reuse race) RTBH: mirror self-heal misses the Auto->Manual upgrade journal write

1 participant