Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Draw API #23

Merged
merged 12 commits into from
Jan 31, 2025
Merged

Conversation

tomhicks
Copy link
Collaborator

@tomhicks tomhicks commented Jan 29, 2025

Adds APIs for selecting drawing tools, setting their options and listeners for those changes.

Copy link
Collaborator Author

tomhicks commented Jan 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tomhicks tomhicks force-pushed the tom/app-6901-allow-choosing-a-draw-tool-via-the-sdk branch 2 times, most recently from 5e7d0b4 to bceb5d6 Compare January 30, 2025 18:11
@tomhicks tomhicks changed the base branch from main to tom/update-typedoc January 30, 2025 18:11
@tomhicks tomhicks mentioned this pull request Jan 30, 2025
@tomhicks tomhicks marked this pull request as ready for review January 31, 2025 09:58
Copy link
Contributor

@Clebal Clebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Clebal Clebal changed the title WIP tool selection Add Draw API Jan 31, 2025
Base automatically changed from tom/update-typedoc to main January 31, 2025 15:09
@tomhicks tomhicks force-pushed the tom/app-6901-allow-choosing-a-draw-tool-via-the-sdk branch from 720087b to 94935bc Compare January 31, 2025 15:10
@tomhicks tomhicks merged commit 3e87812 into main Jan 31, 2025
3 checks passed
@tomhicks tomhicks deleted the tom/app-6901-allow-choosing-a-draw-tool-via-the-sdk branch January 31, 2025 15:11
tomhicks added a commit that referenced this pull request Jan 31, 2025
* WIP tool selection

* Build docs

* Update documentation shape

* Reduce type duplication

* Update Input type for tool settings

* Refine types and docs further

* Fix issue reporting errors from Felt when return type is string

* Update API definition

* Remove unwanted API

* Improve documentation

* docs(changeset): Adds APIs to use Felt's drawing tools on read-only maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants