Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getViewportConstraints and setViewportConstraints methods definition #21

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Jan 28, 2025

This PR adds capabilities to the viewport API for customizing its constraints. Supported constraints are minZoom, maxZoom and bounds.

@Clebal Clebal marked this pull request as ready for review January 30, 2025 14:22
@Clebal Clebal requested a review from tomhicks January 30, 2025 14:22

> **setViewportConstraints**(`constraints`: `null` | `Partial`\<[`ViewportConstraints`](../Viewport/ViewportConstraints.md)>): `void`

Constraints the map viewport so it stays inside certain bounds and/or certain zoom levels.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Constraints the map viewport so it stays inside certain bounds and/or certain zoom levels.
Constrains the map viewport so it stays inside certain bounds and/or certain zoom levels.

@Clebal Clebal force-pushed the sergio/app-6938-implement-getset-viewport-constraints branch from 25964f1 to a12be5b Compare January 31, 2025 15:47
Copy link
Collaborator

@tomhicks tomhicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Clebal Clebal merged commit 1d63d3f into main Jan 31, 2025
2 checks passed
@Clebal Clebal deleted the sergio/app-6938-implement-getset-viewport-constraints branch January 31, 2025 16:04
tomhicks pushed a commit that referenced this pull request Jan 31, 2025
…ion (#21)

* docs(changeset): Add getViewportConstraints and setViewportConstraints methods definition

* Add getViewportConstraints and setViewportConstraints methods definition

* Improve doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants