Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add a workflow that publishes images to DockerHub #92

Merged
merged 12 commits into from
Dec 30, 2021

Conversation

irving-caamal
Copy link
Contributor

@irving-caamal irving-caamal commented Oct 13, 2021

Description

Fixes #88

Type of Change:

  • New Feature

How Has This Been Tested?

  1. Published on my fork you can check it here
  2. You can also check the images
    2. - frontend
    2. - backend
    2. - bot

Steps before merge:

  1. You need to set two secrets on Github Secrets

    • DOCKER_USER (docker hub username)
    • DOCKER_USER (docker hub password)
  2. You need to create formica-bot, formica-frontend, formica-backend repositories on DockerHub (this is an opinion, you could set those each docker push)

Ideas

After publishing all images maybe you can set the image for each service of Formica on the docker-compose.yml file, like so:

backend:
		image: formica/formica-$SERVICE
        build: 
            context: ./backend
            dockerfile: dev.Dockerfile
        volumes:
            - ./backend/:/code/
        ports:
            - "8000:8000"
        depends_on:
            - db

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@irving-caamal
Copy link
Contributor Author

Hi, @felixfaisal thanks for the time and sorry for the late response.

Hope this can help the project.

@felixfaisal felixfaisal merged commit 67dd472 into felixfaisal:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a GitHub workflow to publish images to DockerHub
2 participants