Repository navigation
siguldry-pkcs11: DER-encode certificate serial numbers - #293
Merged
jeremycline merged 2 commits intoOct 28, 2026
Merged
Conversation
Addresses a race condition in tokio::time::Interval Signed-off-by: Jeremy Cline <jeremycline@microsoft.com>
The specification in section 4.6.3 indicates the serial number should be DER-encoded. However, we were using the plain BigNum bytes as the value. Signed-off-by: Jeremy Cline <jeremycline@microsoft.com>
jeremycline
force-pushed
the
pkcs11-serial-encoding
branch
from
October 28, 2026 20:48
1f361dd to
e1d7835
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification in section 4.6.3 indicates the serial number should be DER-encoded. However, we were using the plain BigNum bytes as the value.