Fix tests #3669
Open
Fix tests #3669
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikromen
commented
Mar 13, 2025
| # fedora-review url redirects to the fedora-review/ and wget2 with -A option | ||
| # doesn't follow redirects in this case | ||
| # upstream issue: TODO | ||
| cmd.append(chroot.result_url + "fedora-review/") |
There was a problem hiding this comment.
I honestly have no idea how to make wget2 work here...
reproducer:
try to run:
wget2 -r -nH --no-parent --reject "index.html*" -e robots=off -P /tmp/tmp3 --cut-dirs 6 https://download.copr-dev.fedorainfracloud.org/results/@copr/TEST1741895613756854978FedoraReview2/fedora-41-x86_64/02921806-hello/fedora-reviewwith no accept list items and it correctly redirects and downloads the files... but now if you add something that is in that files that were downloaded e.g. review.txt then it downloads nothing
[root@test-env tmp3]# wget -r -nH --no-parent --reject "index.html*" -e robots=off -P /tmp/tmp3 --cut-dirs 6 -A review.txt https://download.copr-dev.fedorainfracloud.org/results/@copr/TEST1741895613756854978FedoraReview2/fedora-41-x86_64/02921806-hello/fedora-review
HTTP ERROR response 404 [https://download.copr-dev.fedorainfracloud.org/robots.txt]
[0] Checking 'https://download.copr-dev.fedorainfracloud.org/results/@copr/TEST1741895613756854978FedoraReview2/fedora-41-x86_64/02921806-hello/fedora-review' ...
HTTP response 301 [https://download.copr-dev.fedorainfracloud.org/results/@copr/TEST1741895613756854978FedoraReview2/fedora-41-x86_64/02921806-hello/fedora-review]
/tmp/tmp3/fedora-rev 100% [=========================================================================================================================================================================================================================================>] 404 --.-KB/s
[Files: 0 Bytes: 158 [934 B/s] Redirects: 1 Todo: 0 Errors: 1 ]
[root@test-env tmp3]# ls
[root@test-env tmp3]#any ideas how to make it work? I think I am using it right... in that case I'll create upstream issue for wget2
Pull Request validationFailed🔴 Review - Missing review from a member (2 required) Success🟢 CI - All checks have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes beaker tests